Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 624f2fc

Browse files
committed
unskip
1 parent 63759ca commit 624f2fc

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m

+3-9
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@ - (void)ensureApplicationIsInActiveState {
5959
XCTAssertEqual([UIApplication sharedApplication].applicationState, UIApplicationStateActive);
6060
}
6161

62-
// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
63-
// has been identified. https://github.com/flutter/flutter/issues/61620
64-
- (void)skip_testDismissedFlutterViewControllerNotRespondingToApplicationLifecycle {
62+
- (void)testDismissedFlutterViewControllerNotRespondingToApplicationLifecycle {
6563
XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];
6664
// Let the engine finish booting (at the end of which the channels are properly set-up) before
6765
// moving onto the next step of showing the next view controller.
@@ -203,9 +201,7 @@ - (void)skip_testDismissedFlutterViewControllerNotRespondingToApplicationLifecyc
203201
[engine destroyContext];
204202
}
205203

206-
// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
207-
// has been identified. https://github.com/flutter/flutter/issues/61620
208-
- (void)skip_testVisibleFlutterViewControllerRespondsToApplicationLifecycle {
204+
- (void)VisibleFlutterViewControllerRespondsToApplicationLifecycle {
209205
XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];
210206

211207
// Let the engine finish booting (at the end of which the channels are properly set-up) before
@@ -315,9 +311,7 @@ - (void)skip_testVisibleFlutterViewControllerRespondsToApplicationLifecycle {
315311
[engine destroyContext];
316312
}
317313

318-
// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
319-
// has been identified. https://github.com/flutter/flutter/issues/61620
320-
- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle {
314+
- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle {
321315
XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];
322316

323317
// Let the engine finish booting (at the end of which the channels are properly set-up) before

0 commit comments

Comments
 (0)