Address comments

Author: bdero

impeller/scene/mesh.h

@@ -25,13 +25,18 @@ class Mesh final {
   Mesh();
   ~Mesh();
 
+  Mesh(Mesh&& mesh);
+  Mesh& operator=(Mesh&& mesh);
+
   void AddPrimitive(Primitive mesh_);
   std::vector<Primitive>& GetPrimitives();
 
   bool Render(SceneEncoder& encoder, const Matrix& transform) const;
 
  private:
   std::vector<Primitive> primitives_;
+
+  FML_DISALLOW_COPY_AND_ASSIGN(Mesh);
 };
 
 }  // namespace scene

impeller/scene/node.cc

@@ -48,7 +48,7 @@ Node Node::MakeFromFlatbuffer(const fb::Node& node, Allocator& allocator) {
     auto geometry = Geometry::MakeFromFlatbuffer(*primitives, allocator);
     mesh.AddPrimitive({geometry, Material::MakeUnlit()});
   }
-  result.SetMesh(mesh);
+  result.SetMesh(std::move(mesh));
 
   if (!node.children()) {
     return result;
@@ -64,6 +64,10 @@ Node::Node() = default;
 
 Node::~Node() = default;
 
+Mesh::Mesh(Mesh&& mesh) = default;
+
+Mesh& Mesh::operator=(Mesh&& mesh) = default;
+
 Node::Node(Node&& node) = default;
 
 Node& Node::operator=(Node&& node) = default;
@@ -111,8 +115,8 @@ std::vector<Node>& Node::GetChildren() {
   return children_;
 }
 
-void Node::SetMesh(const Mesh& mesh) {
-  mesh_ = mesh;
+void Node::SetMesh(Mesh mesh) {
+  mesh_ = std::move(mesh);
 }
 
 Mesh& Node::GetMesh() {

impeller/scene/node.h

@@ -40,7 +40,7 @@ class Node final {
   bool AddChild(Node child);
   std::vector<Node>& GetChildren();
 
-  void SetMesh(const Mesh& mesh);
+  void SetMesh(Mesh mesh);
   Mesh& GetMesh();
 
   bool Render(SceneEncoder& encoder, const Matrix& parent_transform) const;

impeller/scene/scene_unittests.cc

@@ -47,7 +47,7 @@ TEST_P(SceneTest, CuboidUnlit) {
 
       Node& root = scene.GetRoot();
       root.SetLocalTransform(Matrix::MakeTranslation(-size / 2));
-      root.SetMesh(mesh);
+      root.SetMesh(std::move(mesh));
     }
 
     // Face towards the +Z direction (+X right, +Y up).