Revert "Add tests & --unopt to build_fuchsia_artifacts (#18625)" (#19494)

This reverts commit fae8141.

Author: renyou

BUILD.gn

@@ -169,16 +169,10 @@ if (is_fuchsia) {
       "//flutter/fml:fml_tests",
       "//flutter/runtime:runtime_tests",
       "//flutter/runtime:runtime_tests_next",
+      "//flutter/shell/common:shell_tests",
+      "//flutter/shell/common:shell_tests_next",
       "//flutter/shell/platform/fuchsia/flutter:flutter_runner_scenic_tests",
       "//flutter/shell/platform/fuchsia/flutter:flutter_runner_tests",
     ]
-
-    # TODO(fxb/55353): These break with LTO enabled
-    if (!enable_lto) {
-      deps += [
-        "//flutter/shell/common:shell_tests",
-        "//flutter/shell/common:shell_tests_next",
-      ]
-    }
   }
 }

shell/platform/fuchsia/dart_runner/BUILD.gn

@@ -14,22 +14,11 @@ template("runner") {
   assert(defined(invoker.product), "The parameter 'product' must be defined")
   assert(defined(invoker.output_name),
          "The parameter 'output_name' must be defined")
-  assert(defined(invoker.extra_deps),
-         "The parameter 'extra_deps' must be defined")
 
   invoker_output_name = invoker.output_name
+  extra_defines = invoker.extra_defines
   extra_deps = invoker.extra_deps
 
-  extra_configs = []
-  if (is_debug) {
-    extra_configs += [ "//third_party/dart/build/config:debug" ]
-  }
-
-  extra_defines = []
-  if (defined(invoker.extra_defines)) {
-    extra_defines += invoker.extra_defines
-  }
-
   executable(target_name) {
     output_name = invoker_output_name
 
@@ -46,8 +35,6 @@ template("runner") {
       "service_isolate.h",
     ]
 
-    configs += extra_configs
-
     defines = extra_defines
 
     dart_deps = []
@@ -88,11 +75,10 @@ template("runner") {
 runner("dart_jit_runner_bin") {
   output_name = "dart_jit_runner"
   product = false
-
+  extra_defines = []
   if (flutter_runtime_mode == "profile") {
-    extra_defines = [ "FLUTTER_PROFILE" ]
+    extra_defines += [ "FLUTTER_PROFILE" ]
   }
-
   extra_deps = [
     "//third_party/dart/runtime:libdart_jit",
     "//third_party/dart/runtime/platform:libdart_platform_jit",
@@ -102,9 +88,7 @@ runner("dart_jit_runner_bin") {
 runner("dart_jit_product_runner_bin") {
   output_name = "dart_jit_product_runner"
   product = true
-
   extra_defines = [ "DART_PRODUCT" ]
-
   extra_deps = [
     "//third_party/dart/runtime:libdart_jit_product",
     "//third_party/dart/runtime/platform:libdart_platform_jit_product",
@@ -114,12 +98,10 @@ runner("dart_jit_product_runner_bin") {
 runner("dart_aot_runner_bin") {
   output_name = "dart_aot_runner"
   product = false
-
   extra_defines = [ "AOT_RUNTIME" ]
   if (flutter_runtime_mode == "profile") {
     extra_defines += [ "FLUTTER_PROFILE" ]
   }
-
   extra_deps = [
     "embedder:dart_aot_snapshot_cc",
     "//third_party/dart/runtime:libdart_precompiled_runtime",
@@ -130,12 +112,10 @@ runner("dart_aot_runner_bin") {
 runner("dart_aot_product_runner_bin") {
   output_name = "dart_aot_product_runner"
   product = true
-
   extra_defines = [
     "AOT_RUNTIME",
     "DART_PRODUCT",
   ]
-
   extra_deps = [
     "embedder:dart_aot_product_snapshot_cc",
     "//third_party/dart/runtime:libdart_precompiled_runtime_product",