Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 78b8fbc

Browse files
Enable gtest-parallel for Impeller unit tests (#52004)
Fixes flutter/flutter#143330
1 parent 0402abd commit 78b8fbc

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

testing/run_tests.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -385,6 +385,10 @@ def __str__(self):
385385
'--gtest_shuffle',
386386
]
387387

388+
repeat_flags = [
389+
'--repeat=2',
390+
]
391+
388392

389393
def run_cc_tests(build_dir, executable_filter, coverage, capture_core_dump):
390394
logger.info('Running Engine Unit-tests.')
@@ -393,10 +397,6 @@ def run_cc_tests(build_dir, executable_filter, coverage, capture_core_dump):
393397
import resource # pylint: disable=import-outside-toplevel
394398
resource.setrlimit(resource.RLIMIT_CORE, (resource.RLIM_INFINITY, resource.RLIM_INFINITY))
395399

396-
repeat_flags = [
397-
'--repeat=2',
398-
]
399-
400400
def make_test(name, flags=None, extra_env=None):
401401
if flags is None:
402402
flags = repeat_flags
@@ -507,9 +507,10 @@ def make_test(name, flags=None, extra_env=None):
507507
)
508508
extra_env = metal_validation_env()
509509
extra_env.update(vulkan_validation_env(build_dir))
510-
mac_impeller_unittests_flags = shuffle_flags + [
510+
mac_impeller_unittests_flags = repeat_flags + [
511+
'--gtest_filter=-*OpenGLES', # These are covered in the golden tests.
512+
'--',
511513
'--enable_vulkan_validation',
512-
'--gtest_filter=-*OpenGLES' # These are covered in the golden tests.
513514
]
514515
# Impeller tests are only supported on macOS for now.
515516
run_engine_executable(
@@ -519,6 +520,7 @@ def make_test(name, flags=None, extra_env=None):
519520
mac_impeller_unittests_flags,
520521
coverage=coverage,
521522
extra_env=extra_env,
523+
gtest=True,
522524
# TODO(https://github.com/flutter/flutter/issues/123733): Remove this allowlist.
523525
# See also https://github.com/flutter/flutter/issues/114872.
524526
allowed_failure_output=[
@@ -1272,9 +1274,10 @@ def main():
12721274
build_dir,
12731275
'impeller_unittests',
12741276
engine_filter,
1275-
shuffle_flags,
1277+
repeat_flags,
12761278
coverage=args.coverage,
1277-
extra_env=extra_env
1279+
extra_env=extra_env,
1280+
gtest=True
12781281
)
12791282
finally:
12801283
xvfb.stop_virtual_x(build_name)

0 commit comments

Comments
 (0)