Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 84e80c5

Browse files
authored
[Impeller] Disable blending for Source blend mode (#43162)
All of the backends already respect this property for the first color attachment in the pipeline. ~~Our Vulkan backend disables blending for a whole pipeline if the first color attachment has blending turned off.~~ This has been under our nose but I haven't checked it until now. HSR might not be working on some Vulkan & OpenGLES drivers because of this.
1 parent 72c902c commit 84e80c5

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

impeller/entity/contents/content_context.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ void ContentContextOptions::ApplyToPipelineDescriptor(
4242
color0.src_color_blend_factor = BlendFactor::kZero;
4343
break;
4444
case BlendMode::kSource:
45+
color0.blending_enabled = false;
4546
color0.dst_alpha_blend_factor = BlendFactor::kZero;
4647
color0.dst_color_blend_factor = BlendFactor::kZero;
4748
color0.src_alpha_blend_factor = BlendFactor::kOne;

0 commit comments

Comments
 (0)