whisper words of wisdom

Author: bdero

impeller/entity/contents/contents.cc

@@ -21,7 +21,12 @@ ContentContextOptions OptionsFromPass(const RenderPass& pass) {
   ContentContextOptions opts;
   opts.sample_count = pass.GetSampleCount();
   opts.color_attachment_pixel_format = pass.GetRenderTargetPixelFormat();
-  opts.has_depth_stencil_attachments = pass.HasStencilAttachment();
+
+  bool has_depth_stencil_attachments =
+      pass.HasDepthAttachment() && pass.HasStencilAttachment();
+  FML_DCHECK(pass.HasDepthAttachment() == pass.HasStencilAttachment());
+
+  opts.has_depth_stencil_attachments = has_depth_stencil_attachments;
   return opts;
 }
 

impeller/renderer/render_pass.cc

@@ -12,6 +12,7 @@ RenderPass::RenderPass(std::shared_ptr<const Context> context,
     : context_(std::move(context)),
       sample_count_(target.GetSampleCount()),
       pixel_format_(target.GetRenderTargetPixelFormat()),
+      has_depth_attachment_(target.GetDepthAttachment().has_value()),
       has_stencil_attachment_(target.GetStencilAttachment().has_value()),
       render_target_size_(target.GetRenderTargetSize()),
       render_target_(target),
@@ -27,6 +28,10 @@ PixelFormat RenderPass::GetRenderTargetPixelFormat() const {
   return pixel_format_;
 }
 
+bool RenderPass::HasDepthAttachment() const {
+  return has_depth_attachment_;
+}
+
 bool RenderPass::HasStencilAttachment() const {
   return has_stencil_attachment_;
 }

impeller/renderer/render_pass.h

@@ -156,6 +156,10 @@ class RenderPass : public ResourceBinder {
   /// @brief      The pixel format of the attached render target.
   PixelFormat GetRenderTargetPixelFormat() const;
 
+  //----------------------------------------------------------------------------
+  /// @brief      Whether the render target has a depth attachment.
+  bool HasDepthAttachment() const;
+
   //----------------------------------------------------------------------------
   /// @brief      Whether the render target has an stencil attachment.
   bool HasStencilAttachment() const;
@@ -169,6 +173,7 @@ class RenderPass : public ResourceBinder {
   // a const reference.
   const SampleCount sample_count_;
   const PixelFormat pixel_format_;
+  const bool has_depth_attachment_;
   const bool has_stencil_attachment_;
   const ISize render_target_size_;
   const RenderTarget render_target_;