Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 9bf353d

Browse files
[Impeller] Disable AHB swapchain. (#52713)
The AHB swapchain has correctness issues, which can be observed when running the draw points microbenchmark application. Disable for now until we figure out the sync fence behavior.
1 parent ed8dbd4 commit 9bf353d

File tree

1 file changed

+21
-16
lines changed

1 file changed

+21
-16
lines changed

impeller/renderer/backend/vulkan/swapchain/swapchain_vk.cc

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -55,24 +55,29 @@ std::shared_ptr<SwapchainVK> SwapchainVK::Create(
5555
return nullptr;
5656
}
5757

58-
// TODO(147533): AHB swapchains on emulators are not functional.
59-
const auto emulator = ContextVK::Cast(*context).GetDriverInfo()->IsEmulator();
58+
// TODO(148139): https://github.com/flutter/flutter/issues/148139 sync issues
59+
// on present.
60+
if constexpr (false) {
61+
// TODO(147533): AHB swapchains on emulators are not functional.
62+
const auto emulator =
63+
ContextVK::Cast(*context).GetDriverInfo()->IsEmulator();
6064

61-
// Try AHB swapchains first.
62-
if (!emulator && AHBSwapchainVK::IsAvailableOnPlatform()) {
63-
auto ahb_swapchain = std::shared_ptr<AHBSwapchainVK>(new AHBSwapchainVK(
64-
context, //
65-
window.GetHandle(), //
66-
std::move(surface), //
67-
window.GetSize(), //
68-
enable_msaa //
69-
));
65+
// Try AHB swapchains first.
66+
if (!emulator && AHBSwapchainVK::IsAvailableOnPlatform()) {
67+
auto ahb_swapchain = std::shared_ptr<AHBSwapchainVK>(new AHBSwapchainVK(
68+
context, //
69+
window.GetHandle(), //
70+
std::move(surface), //
71+
window.GetSize(), //
72+
enable_msaa //
73+
));
7074

71-
if (ahb_swapchain->IsValid()) {
72-
return ahb_swapchain;
73-
} else {
74-
VALIDATION_LOG
75-
<< "Could not create AHB swapchain. Falling back to KHR variant.";
75+
if (ahb_swapchain->IsValid()) {
76+
return ahb_swapchain;
77+
} else {
78+
VALIDATION_LOG
79+
<< "Could not create AHB swapchain. Falling back to KHR variant.";
80+
}
7681
}
7782
}
7883

0 commit comments

Comments
 (0)