Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a52397e

Browse files
authored
fuchsia: Compile disabled RasterThreadMerger code (#20984)
1 parent cd580e2 commit a52397e

File tree

2 files changed

+46
-14
lines changed

2 files changed

+46
-14
lines changed

shell/common/rasterizer.cc

-4
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,6 @@ void Rasterizer::Setup(std::unique_ptr<Surface> surface) {
7777
user_override_resource_cache_bytes_);
7878
}
7979
compositor_context_->OnGrContextCreated();
80-
#if !defined(OS_FUCHSIA)
81-
// TODO(sanjayc77): https://github.com/flutter/flutter/issues/53179. Add
82-
// support for raster thread merger for Fuchsia.
8380
if (surface_->GetExternalViewEmbedder() &&
8481
surface_->GetExternalViewEmbedder()->SupportsDynamicThreadMerging() &&
8582
!raster_thread_merger_) {
@@ -98,7 +95,6 @@ void Rasterizer::Setup(std::unique_ptr<Surface> surface) {
9895
}
9996
});
10097
}
101-
#endif
10298
}
10399

104100
void Rasterizer::Teardown() {

shell/common/shell_unittests.cc

+46-10
Original file line numberDiff line numberDiff line change
@@ -497,9 +497,6 @@ TEST_F(ShellTest, FrameRasterizedCallbackIsCalled) {
497497
DestroyShell(std::move(shell));
498498
}
499499

500-
#if !defined(OS_FUCHSIA)
501-
// TODO(sanjayc77): https://github.com/flutter/flutter/issues/53179. Add
502-
// support for raster thread merger for Fuchsia.
503500
TEST_F(ShellTest, ExternalEmbedderNoThreadMerger) {
504501
auto settings = CreateSettingsForFixture();
505502
fml::AutoResetWaitableEvent end_frame_latch;
@@ -548,8 +545,14 @@ TEST_F(ShellTest, ExternalEmbedderNoThreadMerger) {
548545
DestroyShell(std::move(shell));
549546
}
550547

548+
// TODO(https://github.com/flutter/flutter/issues/59816): Enable on fuchsia.
551549
TEST_F(ShellTest,
552-
ExternalEmbedderEndFrameIsCalledWhenPostPrerollResultIsResubmit) {
550+
#if defined(OS_FUCHSIA)
551+
DISABLED_ExternalEmbedderEndFrameIsCalledWhenPostPrerollResultIsResubmit
552+
#else
553+
ExternalEmbedderEndFrameIsCalledWhenPostPrerollResultIsResubmit
554+
#endif
555+
) {
553556
auto settings = CreateSettingsForFixture();
554557
fml::AutoResetWaitableEvent end_frame_latch;
555558
bool end_frame_called = false;
@@ -597,7 +600,14 @@ TEST_F(ShellTest,
597600
DestroyShell(std::move(shell));
598601
}
599602

600-
TEST_F(ShellTest, OnPlatformViewDestroyDisablesThreadMerger) {
603+
// TODO(https://github.com/flutter/flutter/issues/59816): Enable on fuchsia.
604+
TEST_F(ShellTest,
605+
#if defined(OS_FUCHSIA)
606+
DISABLED_OnPlatformViewDestroyDisablesThreadMerger
607+
#else
608+
OnPlatformViewDestroyDisablesThreadMerger
609+
#endif
610+
) {
601611
auto settings = CreateSettingsForFixture();
602612
fml::RefPtr<fml::RasterThreadMerger> raster_thread_merger;
603613
auto end_frame_callback =
@@ -653,7 +663,14 @@ TEST_F(ShellTest, OnPlatformViewDestroyDisablesThreadMerger) {
653663
DestroyShell(std::move(shell));
654664
}
655665

656-
TEST_F(ShellTest, OnPlatformViewDestroyAfterMergingThreads) {
666+
// TODO(https://github.com/flutter/flutter/issues/59816): Enable on fuchsia.
667+
TEST_F(ShellTest,
668+
#if defined(OS_FUCHSIA)
669+
DISABLED_OnPlatformViewDestroyAfterMergingThreads
670+
#else
671+
OnPlatformViewDestroyAfterMergingThreads
672+
#endif
673+
) {
657674
const size_t ThreadMergingLease = 10;
658675
auto settings = CreateSettingsForFixture();
659676
fml::AutoResetWaitableEvent end_frame_latch;
@@ -719,7 +736,14 @@ TEST_F(ShellTest, OnPlatformViewDestroyAfterMergingThreads) {
719736
DestroyShell(std::move(shell));
720737
}
721738

722-
TEST_F(ShellTest, OnPlatformViewDestroyWhenThreadsAreMerging) {
739+
// TODO(https://github.com/flutter/flutter/issues/59816): Enable on fuchsia.
740+
TEST_F(ShellTest,
741+
#if defined(OS_FUCHSIA)
742+
DISABLED_OnPlatformViewDestroyWhenThreadsAreMerging
743+
#else
744+
OnPlatformViewDestroyWhenThreadsAreMerging
745+
#endif
746+
) {
723747
const size_t kThreadMergingLease = 10;
724748
auto settings = CreateSettingsForFixture();
725749
fml::AutoResetWaitableEvent end_frame_latch;
@@ -792,8 +816,14 @@ TEST_F(ShellTest, OnPlatformViewDestroyWhenThreadsAreMerging) {
792816
DestroyShell(std::move(shell));
793817
}
794818

819+
// TODO(https://github.com/flutter/flutter/issues/59816): Enable on fuchsia.
795820
TEST_F(ShellTest,
796-
OnPlatformViewDestroyWithThreadMergerWhileThreadsAreUnmerged) {
821+
#if defined(OS_FUCHSIA)
822+
DISABLED_OnPlatformViewDestroyWithThreadMergerWhileThreadsAreUnmerged
823+
#else
824+
OnPlatformViewDestroyWithThreadMergerWhileThreadsAreUnmerged
825+
#endif
826+
) {
797827
auto settings = CreateSettingsForFixture();
798828
fml::AutoResetWaitableEvent end_frame_latch;
799829
auto end_frame_callback =
@@ -894,9 +924,15 @@ TEST_F(ShellTest, OnPlatformViewDestroyWithoutRasterThreadMerger) {
894924

895925
DestroyShell(std::move(shell));
896926
}
897-
#endif
898927

899-
TEST_F(ShellTest, OnPlatformViewDestroyWithStaticThreadMerging) {
928+
// TODO(https://github.com/flutter/flutter/issues/59816): Enable on fuchsia.
929+
TEST_F(ShellTest,
930+
#if defined(OS_FUCHSIA)
931+
DISABLED_OnPlatformViewDestroyWithStaticThreadMerging
932+
#else
933+
OnPlatformViewDestroyWithStaticThreadMerging
934+
#endif
935+
) {
900936
auto settings = CreateSettingsForFixture();
901937
fml::AutoResetWaitableEvent end_frame_latch;
902938
auto end_frame_callback =

0 commit comments

Comments
 (0)