Remove assorted bad logs. (#53139)

jonahwilliams · web-flow · commit abb4c95e679c · 2024-05-31T04:28:19.000Z
Fixes flutter/flutter#149376 Fixes flutter/flutter#147081 Lets not log Skia on macOS or anything about transfer queues.
diff --git a/impeller/renderer/backend/vulkan/context_vk.cc b/impeller/renderer/backend/vulkan/context_vk.cc
@@ -287,7 +287,6 @@ void ContextVK::Setup(Settings settings) {
     return;
   }
   if (!transfer_queue.has_value()) {
-    FML_LOG(INFO) << "Dedicated transfer queue not avialable.";
     transfer_queue = graphics_queue.value();
   }
   if (!compute_queue.has_value()) {
diff --git a/shell/platform/darwin/graphics/FlutterDarwinContextMetalSkia.mm b/shell/platform/darwin/graphics/FlutterDarwinContextMetalSkia.mm
@@ -65,7 +65,11 @@ - (instancetype)initWithMTLDevice:(id<MTLDevice>)device
       return nil;
     }
 
+    // Only log this message on iOS where the default is Impeller. On macOS
+    // desktop, Skia is still the default and this log is unecessary.
+#if defined(FML_OS_IOS) || defined(FML_OS_IOS_SIM)
     FML_LOG(IMPORTANT) << "Using the Skia rendering backend (Metal).";
+#endif  // defined(FML_OS_IOS) || defined(FML_OS_IOS_SIM)
 
     _resourceContext->setResourceCacheLimit(0u);
   }

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,6 @@ void ContextVK::Setup(Settings settings) {`
`287`	`287`	`return;`
`288`	`288`	`}`
`289`	`289`	`if (!transfer_queue.has_value()) {`
`290`		`- FML_LOG(INFO) << "Dedicated transfer queue not avialable.";`
`291`	`290`	`transfer_queue = graphics_queue.value();`
`292`	`291`	`}`
`293`	`292`	`if (!compute_queue.has_value()) {`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,11 @@ - (instancetype)initWithMTLDevice:(id<MTLDevice>)device`
`65`	`65`	`return nil;`
`66`	`66`	`}`
`67`	`67`
	`68`	`+ // Only log this message on iOS where the default is Impeller. On macOS`
	`69`	`+ // desktop, Skia is still the default and this log is unecessary.`
	`70`	`+#if defined(FML_OS_IOS) \|\| defined(FML_OS_IOS_SIM)`
`68`	`71`	`FML_LOG(IMPORTANT) << "Using the Skia rendering backend (Metal).";`
	`72`	`+#endif // defined(FML_OS_IOS) \|\| defined(FML_OS_IOS_SIM)`
`69`	`73`
`70`	`74`	`_resourceContext->setResourceCacheLimit(0u);`
`71`	`75`	`}`