fix linter issues

Author: iskakaushik

impeller/renderer/backend/vulkan/descriptor_pool_vk.cc

@@ -10,7 +10,7 @@
 
 namespace impeller {
 
-DescriptorPoolVK::DescriptorPoolVK(vk::Device device) {
+DescriptorPoolVK::DescriptorPoolVK(vk::Device device) : device_(device) {
   constexpr size_t kPoolSize = 1024;
 
   std::vector<vk::DescriptorPoolSize> pool_sizes = {
@@ -34,20 +34,24 @@ DescriptorPoolVK::DescriptorPoolVK(vk::Device device) {
       pool_sizes.data()                                      // pool sizes
   };
 
-  auto res = device.createDescriptorPoolUnique(pool_info);
+  auto res = device.createDescriptorPool(pool_info);
   if (res.result != vk::Result::eSuccess) {
     VALIDATION_LOG << "Unable to create a descriptor pool";
     return;
   }
 
-  pool_ = std::move(res.value);
+  pool_ = res.value;
   is_valid_ = true;
 }
 
 vk::DescriptorPool DescriptorPoolVK::GetPool() {
-  return *pool_;
+  return pool_;
 }
 
-DescriptorPoolVK::~DescriptorPoolVK() = default;
+DescriptorPoolVK::~DescriptorPoolVK() {
+  if (is_valid_) {
+    device_.destroyDescriptorPool(pool_);
+  }
+}
 
 }  // namespace impeller

impeller/renderer/backend/vulkan/descriptor_pool_vk.h

@@ -22,7 +22,8 @@ class DescriptorPoolVK {
   vk::DescriptorPool GetPool();
 
  private:
-  vk::UniqueDescriptorPool pool_;
+  vk::Device device_;
+  vk::DescriptorPool pool_;
   bool is_valid_ = false;
 
   FML_DISALLOW_COPY_AND_ASSIGN(DescriptorPoolVK);

impeller/renderer/backend/vulkan/render_pass_vk.cc

@@ -27,11 +27,11 @@ static uint32_t color_flash = 0;
 
 RenderPassVK::RenderPassVK(std::weak_ptr<const Context> context,
                            vk::Device device,
-                           RenderTarget target,
+                           const RenderTarget& target,
                            vk::UniqueCommandBuffer command_buffer,
                            vk::UniqueRenderPass render_pass,
                            SurfaceProducerVK* surface_producer)
-    : RenderPass(context, target),
+    : RenderPass(std::move(context), target),
       device_(device),
       command_buffer_(std::move(command_buffer)),
       render_pass_(std::move(render_pass)),
@@ -91,10 +91,6 @@ bool RenderPassVK::OnEncodeCommands(const Context& context) const {
   clear_value.color =
       vk::ClearColorValue(std::array<float, 4>{0.0f, 0.0f, 0.0, 0.0f});
 
-  std::array<vk::ImageView, 1> fbo_attachments = {
-      tex_info.swapchain_image->GetImageView(),
-  };
-
   const auto& size = tex_info.swapchain_image->GetSize();
   vk::Rect2D render_area =
       vk::Rect2D()
@@ -377,7 +373,7 @@ vk::Framebuffer RenderPassVK::CreateFrameBuffer(
                                                  .setLayers(1);
   auto res = device_.createFramebuffer(fb_create_info);
   FML_CHECK(res.result == vk::Result::eSuccess);
-  return std::move(res.value);
+  return res.value;
 }
 
 bool RenderPassVK::TransitionImageLayout(uint32_t frame_num,
@@ -401,6 +397,11 @@ bool RenderPassVK::TransitionImageLayout(uint32_t frame_num,
   vk::CommandBufferBeginInfo begin_info;
   auto res = transition_cmd->begin(begin_info);
 
+  if (res != vk::Result::eSuccess) {
+    VALIDATION_LOG << "Failed to begin command buffer: " << vk::to_string(res);
+    return false;
+  }
+
   vk::ImageMemoryBarrier barrier =
       vk::ImageMemoryBarrier()
           .setSrcAccessMask(vk::AccessFlagBits::eColorAttachmentRead)

impeller/renderer/backend/vulkan/render_pass_vk.h

@@ -21,7 +21,7 @@ class RenderPassVK final : public RenderPass {
  public:
   RenderPassVK(std::weak_ptr<const Context> context,
                vk::Device device,
-               RenderTarget target,
+               const RenderTarget& target,
                vk::UniqueCommandBuffer command_buffer,
                vk::UniqueRenderPass render_pass,
                SurfaceProducerVK* surface_producer);

impeller/renderer/backend/vulkan/texture_vk.cc

@@ -46,9 +46,13 @@ bool TextureVK::OnSetContents(const uint8_t* contents,
 
   // currently we are only supporting 2d textures, no cube textures etc.
   auto mapping = texture_info_->allocated_texture.allocation_info.pMappedData;
-  memcpy(mapping, contents, length);
 
-  return true;
+  if (mapping) {
+    memcpy(mapping, contents, length);
+    return true;
+  } else {
+    return false;
+  }
 }
 
 bool TextureVK::OnSetContents(std::shared_ptr<const fml::Mapping> mapping,