[et] Improve the logger for the ninja build, adds a spinner

Author: zanderso

tools/engine_tool/lib/src/commands/build_command.dart

@@ -5,10 +5,9 @@
 import 'package:engine_build_configs/engine_build_configs.dart';
 
 import '../build_utils.dart';
-
+import '../logger.dart';
 import 'command.dart';
-
-const String _configFlag = 'config';
+import 'flags.dart';
 
 // TODO(johnmccutchan): Should BuildConfig be BuilderConfig and GlobalBuild be BuildConfig?
 // TODO(johnmccutchan): List all available build targets and allow the user
@@ -24,20 +23,26 @@ final class BuildCommand extends CommandBase {
   }) {
     builds = runnableBuilds(environment, configs);
     // Add options here that are common to all queries.
-    argParser.addOption(
-      _configFlag,
-      abbr: 'c',
-      defaultsTo: 'host_debug',
-      help: 'Specify the build config to use',
-      allowed: <String>[
-        for (final GlobalBuild config in runnableBuilds(environment, configs))
-          config.name,
-      ],
-      allowedHelp: <String, String>{
-        for (final GlobalBuild config in runnableBuilds(environment, configs))
-          config.name: config.gn.join(' '),
-      },
-    );
+    argParser
+      ..addOption(
+        configFlag,
+        abbr: 'c',
+        defaultsTo: 'host_debug',
+        help: 'Specify the build config to use',
+        allowed: <String>[
+          for (final GlobalBuild config in runnableBuilds(environment, configs))
+            config.name,
+        ],
+        allowedHelp: <String, String>{
+          for (final GlobalBuild config in runnableBuilds(environment, configs))
+            config.name: config.gn.join(' '),
+        },
+      )
+      ..addFlag(
+        runTestsFlag,
+        help: 'Whether to run tests after building.',
+        defaultsTo: true,
+      );
   }
 
   /// List of compatible builds.
@@ -51,7 +56,8 @@ final class BuildCommand extends CommandBase {
 
   @override
   Future<int> run() async {
-    final String configName = argResults![_configFlag] as String;
+    final String configName = argResults![configFlag] as String;
+    final bool runTests = argResults![runTestsFlag] as bool;
     final GlobalBuild? build = builds
         .where((GlobalBuild build) => build.name == configName)
         .firstOrNull;
@@ -60,28 +66,38 @@ final class BuildCommand extends CommandBase {
       return 1;
     }
     final GlobalBuildRunner buildRunner = GlobalBuildRunner(
-        platform: environment.platform,
-        processRunner: environment.processRunner,
-        abi: environment.abi,
-        engineSrcDir: environment.engine.srcDir,
-        build: build);
+      platform: environment.platform,
+      processRunner: environment.processRunner,
+      abi: environment.abi,
+      engineSrcDir: environment.engine.srcDir,
+      build: build,
+      runTests: runTests,
+    );
+
+    Spinner? spinner;
     void handler(RunnerEvent event) {
       switch (event) {
         case RunnerStart():
-          environment.logger.info('$event: ${event.command.join(' ')}');
+          environment.logger.status('$event     ', newline: false);
+          spinner = environment.logger.startSpinner();
         case RunnerProgress(done: true):
+          spinner?.finish();
+          spinner = null;
           environment.logger.clearLine();
           environment.logger.status(event);
-        case RunnerProgress(done: false):
-          {
-            final String percent = '${event.percent.toStringAsFixed(1)}%';
-            final String fraction = '(${event.completed}/${event.total})';
-            final String prefix = '[${event.name}] $percent $fraction ';
-            final String what = event.what;
-            environment.logger.clearLine();
-            environment.logger.status('$prefix$what');
-          }
+        case RunnerProgress(done: false): {
+          spinner?.finish();
+          spinner = null;
+          final String percent = '${event.percent.toStringAsFixed(1)}%';
+          final String fraction = '(${event.completed}/${event.total})';
+          final String prefix = '[${event.name}] $percent $fraction ';
+          final String what = event.what;
+          environment.logger.clearLine();
+          environment.logger.status('$prefix$what', newline: false, fit: true);
+        }
         default:
+          spinner?.finish();
+          spinner = null;
           environment.logger.status(event);
       }
     }

tools/engine_tool/lib/src/commands/flags.dart

@@ -13,6 +13,8 @@
 // Keep this list alphabetized.
 const String allFlag = 'all';
 const String builderFlag = 'builder';
+const String configFlag = 'config';
 const String dryRunFlag = 'dry-run';
 const String quietFlag = 'quiet';
+const String runTestsFlag = 'run-tests';
 const String verboseFlag = 'verbose';