Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit cead6ed

Browse files
author
nturgut
committed
addresing reviewer comments
1 parent ce17bfc commit cead6ed

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

lib/web_ui/lib/src/engine/text_editing/text_capitalization.dart

+9-10
Original file line numberDiff line numberDiff line change
@@ -27,25 +27,24 @@ enum TextCapitalization {
2727

2828
/// Helper class for text capitalization.
2929
///
30-
/// Uses `text-transform` css property.
31-
/// See: https://developer.mozilla.org/en-US/docs/Web/CSS/text-transform
30+
/// Uses `autocapitalize` attribute on input element.
31+
/// See: https://developers.google.com/web/updates/2015/04/autocapitalize
32+
/// https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/autocapitalize
3233
class TextCapitalizationConfig {
3334
final TextCapitalization textCapitalization;
3435

35-
static final RegExp wordExp = new RegExp(r"(\w+)");
36-
static final RegExp whiteSpaceExp = new RegExp(r"(\s+)");
37-
3836
const TextCapitalizationConfig.defaultCapitalization()
3937
: textCapitalization = TextCapitalization.none;
4038

41-
// TODO: support sentence level text capitalization.
4239
TextCapitalizationConfig.fromInputConfiguration(String inputConfiguration)
4340
: this.textCapitalization =
4441
inputConfiguration == 'TextCapitalization.words'
4542
? TextCapitalization.words
46-
: (inputConfiguration == 'TextCapitalization.characters')
43+
: inputConfiguration == 'TextCapitalization.characters'
4744
? TextCapitalization.characters
48-
: TextCapitalization.none;
45+
: inputConfiguration == 'TextCapitalization.sentences'
46+
? TextCapitalization.sentences
47+
: TextCapitalization.none;
4948

5049
/// Sets `autocapitalize` attribute on input elements.
5150
///
@@ -64,8 +63,8 @@ class TextCapitalizationConfig {
6463
// TODO: There is a bug for `words` level capitalization in IOS now.
6564
// For now go back to default. Remove the check after bug is resolved.
6665
// https://bugs.webkit.org/show_bug.cgi?id=148504
67-
if(browserEngine == BrowserEngine.webkit) {
68-
autocapitalize = 'sentences';
66+
if (browserEngine == BrowserEngine.webkit) {
67+
autocapitalize = 'sentences';
6968
} else {
7069
autocapitalize = 'words';
7170
}

0 commit comments

Comments
 (0)