Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit efd08e9

Browse files
Reverts "Disable Impeller when the manifest explicitly disables it (#53108)" (#53124)
Reverts: #53108 Initiated by: jonahwilliams Reason for reverting: Probably --no-enable-impeller isn't working Original PR Author: jiahaog Reviewed By: {jonahwilliams} This change reverts the following previous change: After #53099, impeller is always enabled, even if the manifest disables it using `io.flutter.embedding.android.EnableImpeller`. This PR causes it to respect the manifest value if it is explicitly disabled. Fixes b/343603270 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 8f63466 commit efd08e9

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

shell/platform/android/io/flutter/embedding/engine/loader/FlutterLoader.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -340,10 +340,8 @@ public void ensureInitializationComplete(
340340
shellArgs.add("--prefetched-default-font-manager");
341341

342342
if (metaData != null) {
343-
if (metaData.getBoolean(ENABLE_IMPELLER_META_DATA_KEY, true)) {
343+
if (metaData.getBoolean(ENABLE_IMPELLER_META_DATA_KEY, false)) {
344344
shellArgs.add("--enable-impeller");
345-
} else {
346-
shellArgs.add("--enable-impeller=false");
347345
}
348346
if (metaData.getBoolean(ENABLE_VULKAN_VALIDATION_META_DATA_KEY, false)) {
349347
shellArgs.add("--enable-vulkan-validation");

0 commit comments

Comments
 (0)