@@ -422,25 +422,27 @@ def make_test(name, flags=repeat_flags, extra_env={}):
422
422
shuffle_flags ,
423
423
coverage = coverage
424
424
)
425
+ # TODO(117122): Re-enable impeller_unittests after shader compiler errors
426
+ # are addressed.
425
427
# Impeller tests are only supported on macOS for now.
426
- RunEngineExecutable (
427
- build_dir ,
428
- 'impeller_unittests' ,
429
- filter ,
430
- shuffle_flags ,
431
- coverage = coverage ,
432
- extra_env = {
433
- # See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc
434
- 'MTL_SHADER_VALIDATION' :
435
- '1' , # Enables all shader validation tests.
436
- 'MTL_SHADER_VALIDATION_GLOBAL_MEMORY' :
437
- '1' , # Validates accesses to device and constant memory.
438
- 'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY' :
439
- '1' , # Validates accesses to threadgroup memory.
440
- 'MTL_SHADER_VALIDATION_TEXTURE_USAGE' :
441
- '1' , # Validates that texture references are not nil.
442
- }
443
- )
428
+ # RunEngineExecutable(
429
+ # build_dir,
430
+ # 'impeller_unittests',
431
+ # filter,
432
+ # shuffle_flags,
433
+ # coverage=coverage,
434
+ # extra_env={
435
+ # # See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc
436
+ # 'MTL_SHADER_VALIDATION':
437
+ # '1', # Enables all shader validation tests.
438
+ # 'MTL_SHADER_VALIDATION_GLOBAL_MEMORY':
439
+ # '1', # Validates accesses to device and constant memory.
440
+ # 'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY':
441
+ # '1', # Validates accesses to threadgroup memory.
442
+ # 'MTL_SHADER_VALIDATION_TEXTURE_USAGE':
443
+ # '1', # Validates that texture references are not nil.
444
+ # }
445
+ # )
444
446
445
447
446
448
def ParseImpellerVulkanFilter ():
0 commit comments