Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit fe734bd

Browse files
authored
Add TextRange::Contains tests spanning base/extent (#21874)
Adds tests for TextRange::Contains(const TextRange&) where the range being tested spans the base/extent of the testing range. This was originally intended to land in #21854, but it seems I didn't push the additional tests before landing.
1 parent 335531c commit fe734bd

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

shell/platform/common/cpp/text_range_unittests.cc

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,11 @@ TEST(TextRange, ContainsRangePreStartPosition) {
107107
EXPECT_FALSE(range.Contains(TextRange(0, 1)));
108108
}
109109

110+
TEST(TextRange, ContainsRangeSpanningStartPosition) {
111+
TextRange range(2, 6);
112+
EXPECT_FALSE(range.Contains(TextRange(1, 3)));
113+
}
114+
110115
TEST(TextRange, ContainsRangeStartPosition) {
111116
TextRange range(2, 6);
112117
EXPECT_TRUE(range.Contains(TextRange(2)));
@@ -123,6 +128,11 @@ TEST(TextRange, ContainsRangeEndPosition) {
123128
EXPECT_TRUE(range.Contains(TextRange(6)));
124129
}
125130

131+
TEST(TextRange, ContainsRangeSpanningEndPosition) {
132+
TextRange range(2, 6);
133+
EXPECT_FALSE(range.Contains(TextRange(5, 7)));
134+
}
135+
126136
TEST(TextRange, ContainsRangePostEndPosition) {
127137
TextRange range(2, 6);
128138
EXPECT_FALSE(range.Contains(TextRange(6, 7)));
@@ -133,6 +143,11 @@ TEST(TextRange, ContainsRangePreStartPositionReversed) {
133143
EXPECT_FALSE(range.Contains(TextRange(0, 1)));
134144
}
135145

146+
TEST(TextRange, ContainsRangeSpanningStartPositionReversed) {
147+
TextRange range(6, 2);
148+
EXPECT_FALSE(range.Contains(TextRange(1, 3)));
149+
}
150+
136151
TEST(TextRange, ContainsRangeStartPositionReversed) {
137152
TextRange range(6, 2);
138153
EXPECT_TRUE(range.Contains(TextRange(2)));
@@ -144,6 +159,11 @@ TEST(TextRange, ContainsRangeMiddlePositionReversed) {
144159
EXPECT_TRUE(range.Contains(TextRange(4, 5)));
145160
}
146161

162+
TEST(TextRange, ContainsRangeSpanningEndPositionReversed) {
163+
TextRange range(6, 2);
164+
EXPECT_FALSE(range.Contains(TextRange(5, 7)));
165+
}
166+
147167
TEST(TextRange, ContainsRangeEndPositionReversed) {
148168
TextRange range(6, 2);
149169
EXPECT_TRUE(range.Contains(TextRange(5)));

0 commit comments

Comments
 (0)