From 763799d56fb88d009f9dfde82a87089af05f796d Mon Sep 17 00:00:00 2001 From: Brandon DeRosier Date: Thu, 2 Feb 2023 01:19:15 -0800 Subject: [PATCH 1/2] [Impeller] Don't ceil subpass texture sizes --- impeller/entity/entity_pass.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/impeller/entity/entity_pass.cc b/impeller/entity/entity_pass.cc index 346e636eb763d..33eba1688e835 100644 --- a/impeller/entity/entity_pass.cc +++ b/impeller/entity/entity_pass.cc @@ -324,11 +324,11 @@ EntityPass::EntityResult EntityPass::GetEntityForElement( RenderTarget subpass_target; if (subpass->reads_from_pass_texture_ > 0) { - subpass_target = CreateRenderTarget( - renderer, ISize::Ceil(subpass_coverage->size), true); + subpass_target = + CreateRenderTarget(renderer, ISize(subpass_coverage->size), true); } else { - subpass_target = CreateRenderTarget( - renderer, ISize::Ceil(subpass_coverage->size), false); + subpass_target = + CreateRenderTarget(renderer, ISize(subpass_coverage->size), false); } auto subpass_texture = subpass_target.GetRenderTargetTexture(); From 5161d561d3c655e683888e267494eb59a3824a65 Mon Sep 17 00:00:00 2001 From: Brandon DeRosier Date: Thu, 2 Feb 2023 11:51:58 -0800 Subject: [PATCH 2/2] Better conditional --- impeller/entity/entity_pass.cc | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/impeller/entity/entity_pass.cc b/impeller/entity/entity_pass.cc index 33eba1688e835..df9e860f2c48b 100644 --- a/impeller/entity/entity_pass.cc +++ b/impeller/entity/entity_pass.cc @@ -322,14 +322,10 @@ EntityPass::EntityResult EntityPass::GetEntityForElement( return EntityPass::EntityResult::Skip(); } - RenderTarget subpass_target; - if (subpass->reads_from_pass_texture_ > 0) { - subpass_target = - CreateRenderTarget(renderer, ISize(subpass_coverage->size), true); - } else { - subpass_target = - CreateRenderTarget(renderer, ISize(subpass_coverage->size), false); - } + auto subpass_target = + CreateRenderTarget(renderer, // + ISize(subpass_coverage->size), // + subpass->reads_from_pass_texture_ > 0); auto subpass_texture = subpass_target.GetRenderTargetTexture();