Skip to content

Commit 00f4066

Browse files
authored
Exclude abi key in local golden file testing (#148023)
Part of #148022
1 parent 2603055 commit 00f4066

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

packages/flutter_goldens/lib/skia_client.dart

+2-1
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,8 @@ class SkiaGoldClient {
589589
'WebRenderer' : webRenderer,
590590
'CI' : 'luci',
591591
'Platform' : platform.operatingSystem,
592-
'Abi': abi.toString(),
592+
// 'Abi': abi.toString(), workaround for https://g-issues.skia.org/issues/339508268
593+
// Flutter tracking issue: https://github.com/flutter/flutter/issues/148022
593594
'name' : testName,
594595
'source_type' : 'flutter',
595596
if (_isImpeller)

packages/flutter_goldens/test/flutter_goldens_test.dart

+3-3
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ void main() {
499499

500500
expect(
501501
skiaClient.getTraceID('flutter.golden.1'),
502-
equals('1937c1c93610cc0122a86a83d5bd38a4'),
502+
equals('ae18c7a6aa48e0685525dfe8fdf79003'),
503503
);
504504
});
505505

@@ -533,7 +533,7 @@ void main() {
533533

534534
expect(
535535
skiaClient.getTraceID('flutter.golden.1'),
536-
equals('bc44a50c01eb3bbaf72a80d76c1c2305'),
536+
equals('e9d5c296c48e7126808520e9cc191243'),
537537
);
538538
});
539539

@@ -561,7 +561,7 @@ void main() {
561561
);
562562
expect(
563563
skiaClient.getTraceID('flutter.golden.1'),
564-
equals('8821f4896801fcdd7cd6d30f5a8e4284'),
564+
equals('9968695b9ae78cdb77cbb2be621ca2d6'),
565565
);
566566
});
567567

0 commit comments

Comments
 (0)