Skip to content

Abstract Builder class to share some parameters #114567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nayuta403 opened this issue Nov 3, 2022 · 0 comments
Open

Abstract Builder class to share some parameters #114567

Nayuta403 opened this issue Nov 3, 2022 · 0 comments
Labels
c: proposal A detailed proposal for a change to Flutter engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team

Comments

@Nayuta403
Copy link

Nayuta403 commented Nov 3, 2022

Use case

Create from:
flutter/engine#36963 (comment)

Now we have too many builders, NewEngineIntentBuilder, CachedEngineIntentBuilder, as well as the increase of NewEngineInGroupIntentBuilder. They have some common parameters (especially NewEngineIntentBuilder and NewEngineInGroupIntentBuilder, because they are starting a new engine), in FlutterActivity, FlutterFragmentActivity, FlutterFragment all appear.

Proposal

Abstract a Builder class with some parameters used by Dart like entryPoint, initialRoute, dartEntrypointArgs. Then Actvitity or fragments of the Builder extends from this class, and contains specific attributes, such as activityClass/fragmentClass. Many of such NewEngineIntentBuilder and NewEngineInGroupIntentBuilder fields can be Shared.

@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team platform-android Android applications specifically engine flutter/engine repository. See also e: labels. c: proposal A detailed proposal for a change to Flutter and removed in triage Presently being triaged by the triage team labels Nov 3, 2022
@chinmaygarde chinmaygarde added the P3 Issues that are less important to the Flutter project label Nov 7, 2022
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: proposal A detailed proposal for a change to Flutter engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project platform-android Android applications specifically team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
None yet
Development

No branches or pull requests

4 participants