Skip to content

Make ImageProvider.loadImage() abstract #119209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tvolkert opened this issue Jan 26, 2023 · 3 comments
Open

Make ImageProvider.loadImage() abstract #119209

tvolkert opened this issue Jan 26, 2023 · 3 comments
Labels
a: images Loading, displaying, rendering images c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team

Comments

@tvolkert
Copy link
Contributor

tvolkert commented Jan 26, 2023 •
edited
Loading

In #118966, we added ImageProvider.loadImage(). This method should be abstract in ImageProvider, but due to the need for backwards compatibility, it was made as a non-abstract method to allow subclasses time to migrate.

Once the deprecation period for the old method (loadBuffer()) is over and that method is removed, the base ImageProvider.loadImage() should be made abstract.
@tvolkert tvolkert added framework flutter/packages/flutter repository. See also f: labels. a: images Loading, displaying, rendering images P3 Issues that are less important to the Flutter project c: tech-debt Technical debt, code quality, testing, etc. labels Jan 26, 2023
@shogohida
Copy link
Contributor

shogohida commented Jan 29, 2023 •
edited
Loading

Hi @tvolkert, can I work on this? When will be the deprecation period for the old method (loadBuffer()) over?

@tvolkert
Copy link
Contributor Author

tvolkert commented Feb 1, 2023

Hi @shogohida, loadBuffer() was just just deprecated in #118966, so we won't be able to remove it (and make loadImage() abstract) for about a year.

@flutter-triage-bot flutter-triage-bot bot added team-framework Owned by Framework team triaged-framework Triaged by Framework team labels Jul 8, 2023
@tvolkert
Copy link
Contributor Author

This is ready to be done now, as we're outside of the deprecation period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: images Loading, displaying, rendering images c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project team-framework Owned by Framework team triaged-framework Triaged by Framework team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shogohida @tvolkert