Skip to content

[Impeller] Investigate if glyphs should be cached with a canonicalized color #126101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonahwilliams opened this issue May 4, 2023 · 2 comments · Fixed by flutter/engine#41780
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project waiting for PR to land (fixed) A fix is in flight

Comments

@jonahwilliams
Copy link
Member

Skia uses https://github.com/google/skia/blob/f8a6c43e67847902aa3779482ca78e7beb88ebe4/src/text/gpu/TextBlob.cpp#L60 to compute a canonical color for caching glyphs. The color the text is drawn with has an implact on the anti aliasing pixels.

Previously we made a tradeoff to make dark text on light backgrounds look better, potentially at the cost of light text on dark backgrounds.

@jonahwilliams jonahwilliams added engine flutter/engine repository. See also e: labels. e: impeller Impeller rendering backend issues and features requests labels May 4, 2023
@jonahwilliams
Copy link
Member Author

Actually, we may not need to worry about this - isntead using an A8 or R8 may just fix this since we can treat the glyph as coverage data and not worry about color info.

@chinmaygarde chinmaygarde added the P3 Issues that are less important to the Flutter project label May 8, 2023
@github-project-automation github-project-automation bot moved this to 🤔 Needs Triage in Impeller May 8, 2023
@chinmaygarde chinmaygarde moved this from 🤔 Needs Triage to ⚡ Performance in Impeller May 8, 2023
@chinmaygarde chinmaygarde added the waiting for PR to land (fixed) A fix is in flight label May 8, 2023
@github-project-automation github-project-automation bot moved this from ⚡ Performance to ✅ Done in Impeller May 10, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e: impeller Impeller rendering backend issues and features requests engine flutter/engine repository. See also e: labels. P3 Issues that are less important to the Flutter project waiting for PR to land (fixed) A fix is in flight
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants