Reconcile Android/iOS on usage of a builder when creating activity/vc

[xster]

No description provided.

[xster]

On Android, starting an activity with a new engine has a builder (NewEngineIntentBuilder)
https://github.com/flutter/engine/blob/101e03c1c8417267c20fb9f448a8efb80ec2c328/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java#L223 to specify the initial route (dart entrypoint was recently removed out of security concerns wrt android intents)

On Android, starting an engine has arguments (DartEntrypoint) https://github.com/flutter/engine/blob/101e03c1c8417267c20fb9f448a8efb80ec2c328/shell/platform/android/io/flutter/embedding/engine/dart/DartExecutor.java#L256 to specify the VM entrypoint function and the path to the dart bundle.

On iOS, starting a VC has arguments to specify the bundle (https://github.com/flutter/engine/blob/101e03c1c8417267c20fb9f448a8efb80ec2c328/shell/platform/darwin/ios/framework/Headers/FlutterViewController.h#L69) for the Flutter library and nib.

On iOS, starting the engine has arguments to specify the bundle for the Flutter library https://github.com/flutter/engine/blob/101e03c1c8417267c20fb9f448a8efb80ec2c328/shell/platform/darwin/ios/framework/Headers/FlutterEngine.h#L80.

We should be consistent about options provided when starting Flutter.

Ideally, in all cases, we should be able to provide the Flutter library location, the entrypoint and the initial route (with Android activity starting via Intent being one exception)

[xster]

cc @gaaclarke, we just talked about this in person.

[xster]

This doesn't solve the general platform channel timing issue such as #38914 but it would solve a lot of initial route specific timing issues, especially on iOS such as #27882, #27216.

[matthew-carroll]

@gaaclarke do you think you've made all the changes that you want to make for this issue? Or are you still investigating API refactors?

[gaaclarke]

I have nothing in the works. I gave up on FlutterEngineBuilder. I'm open to any other ideas, I've been focusing my energy elsewhere.

[matthew-carroll]

Similar to the other ticket, let's see if we can come up with a definition of done for this ticket on Thursday. If the answer is "won't do" then we can close it on Thursday. If there is something we should do, let's see if we can define it and then we can prioritize its delivery.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.