Skip to content

Flutter test's output on test failure is too verbose. #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apwilson opened this issue May 6, 2016 · 3 comments
Closed

Flutter test's output on test failure is too verbose. #3790

apwilson opened this issue May 6, 2016 · 3 comments
Labels
a: tests "flutter test", flutter_test, or one of our tests c: regression It was better in the past than it is now customer: fuchsia

Comments

@apwilson
Copy link
Contributor

apwilson commented May 6, 2016

I currently get 156 lines of exception backtraces with relevant information embeded within it.

Only 10 lines of the 156 lines are actually useful: ie. they tell me what the failure is and where.

We can do better.

Maybe we need to make a metric for the board. % lines of test failure useful: 6%

@apwilson apwilson added a: tests "flutter test", flutter_test, or one of our tests c: regression It was better in the past than it is now c: contributor-productivity Team-specific productivity, code health, technical debt. customer: fuchsia c: performance Relates to speed or footprint issues (see "perf:" labels) labels May 6, 2016
@Hixie Hixie removed c: performance Relates to speed or footprint issues (see "perf:" labels) c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 8, 2016
@Hixie Hixie added this to the Flutter 1.0 milestone May 8, 2016
@Hixie
Copy link
Contributor

Hixie commented May 8, 2016

There's three bugs here.

  • when _runTest throws an exception, it's printed twice #3639 - for some reason, the test framework outputs tests twice.
  • I can't control the output of the test framework in the first place. If I could, I'd make the exceptions prettier without needing to throw a fake one.
  • We don't currently post-process the stack traces to remove dart-internal frames. I plan to add that at some point.

@Hixie
Copy link
Contributor

Hixie commented May 16, 2016

Fixed by #3936.

@Hixie Hixie closed this as completed May 16, 2016
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: tests "flutter test", flutter_test, or one of our tests c: regression It was better in the past than it is now customer: fuchsia
Projects
None yet
Development

No branches or pull requests

2 participants