Skip to content

flutter/packages should enforce an expected clang-format version #39767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mklim opened this issue Sep 3, 2019 · 1 comment
Open

flutter/packages should enforce an expected clang-format version #39767

mklim opened this issue Sep 3, 2019 · 1 comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. p: tooling Affects the flutter_plugin_tools package P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team

Comments

@mklim
Copy link
Contributor

mklim commented Sep 3, 2019

Right now our formatting tools use whatever version of clang-format is in the user's path, but CI always uses clang-format-7. Apparently this has also changed over time, since looking at the related issue #12864 there's some mention of CI using clang-format-5. Formatting differences from clang-format version mismatches are hard to diagnose and can even be introduced just from running the formatting tool without any arguments. Ideally pub global run flutter_plugin_tools format should know what clang-format version CI is expecting and either download it itself (ideal) or throw if it can't find it.
@mklim mklim added c: contributor-productivity Team-specific productivity, code health, technical debt. plugin labels Sep 3, 2019
@mklim mklim mentioned this issue Sep 3, 2019
Merged
13 tasks
@stuartmorgan-g stuartmorgan-g added the P3 Issues that are less important to the Flutter project label May 16, 2021
@stuartmorgan-g stuartmorgan-g mentioned this issue Jul 1, 2021
Closed
@stuartmorgan-g stuartmorgan-g mentioned this issue Jul 12, 2021
Merged
11 tasks
@stuartmorgan-g stuartmorgan-g mentioned this issue Oct 25, 2021
Merged
11 tasks
@stuartmorgan-g stuartmorgan-g changed the title flutter/plugins should enforce an expected clang-format version flutter/packages should enforce an expected clang-format version Mar 6, 2023
@stuartmorgan-g stuartmorgan-g added p: tooling Affects the flutter_plugin_tools package package flutter/packages repository. See also p: labels. and removed plugin labels Mar 6, 2023
@flutter-triage-bot flutter-triage-bot bot added team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team labels Jul 8, 2023
@stuartmorgan-g
Copy link
Contributor

Downloading is out of scope (see #12864), but warning on version mismatch is reasonable.

@stuartmorgan-g stuartmorgan-g mentioned this issue Mar 6, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. p: tooling Affects the flutter_plugin_tools package P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuartmorgan-g @mklim