Skip to content

Audit our binary size #6177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks
Hixie opened this issue Oct 3, 2016 · 3 comments
Closed
3 tasks

Audit our binary size #6177

Hixie opened this issue Oct 3, 2016 · 3 comments
Labels
a: size Reducing IPA/APK/JS sizes c: contributor-productivity Team-specific productivity, code health, technical debt. c: performance Relates to speed or footprint issues (see "perf:" labels) dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. perf: app size Performance issues related to app size (binary/code size) or disk space

Comments

@Hixie
Copy link
Contributor

Hixie commented Oct 3, 2016

Things to consider removing from release builds:

  • skia image encoders (PNG encoder is used for screenshot feature in debug mode)
  • skia has a table of square roots that seems unnecessary
  • We should make sure DartVM doesn't have a parser for Dart source code
@Hixie Hixie added c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine repository. See also e: labels. labels Oct 3, 2016
@Hixie Hixie added this to the 4: Make Hixie proud milestone Oct 3, 2016
@tvolkert
Copy link
Contributor

tvolkert commented May 24, 2017

Other things to consider:

  • Tree-shaking the material icons font to include only the icons the app uses Tree shake material icons #16311
  • Investigating to see if there's anything included in the app snapshot that could be removed from release builds

@zoechi zoechi added a: size Reducing IPA/APK/JS sizes dependency: dart Dart team may need to help us labels Nov 29, 2018
@Hixie Hixie modified the milestones: Stretch Goals, New Stretch Goals Jan 7, 2020
@dnfield
Copy link
Contributor

dnfield commented Feb 11, 2020

I'm going to close this bug.

We can't remove image encoders - in particular, PNG is needed for freetype.

AFAICT, Skia has removed the table of roots, and the Dart VM doesn't contain a parser for VM code.

We've impelemnted tree shaking of material icons.

The Dart team is tracking AOT size with these bugs: https://github.com/dart-lang/sdk/issues?q=is%3Aopen+is%3Aissue+label%3Avm-aot-code-size

We're tracking size with these bugs: a: size Reducing IPA/APK/JS sizes

There's at least one other bug currently that could also reduce size: dart-lang/sdk#39104

@dnfield dnfield closed this as completed Feb 11, 2020
@liyuqian liyuqian added the perf: app size Performance issues related to app size (binary/code size) or disk space label Mar 8, 2020
@liyuqian liyuqian added the c: performance Relates to speed or footprint issues (see "perf:" labels) label Mar 30, 2020
@lock
Copy link

lock bot commented Apr 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: size Reducing IPA/APK/JS sizes c: contributor-productivity Team-specific productivity, code health, technical debt. c: performance Relates to speed or footprint issues (see "perf:" labels) dependency: dart Dart team may need to help us engine flutter/engine repository. See also e: labels. perf: app size Performance issues related to app size (binary/code size) or disk space
Projects
None yet
Development

No branches or pull requests

5 participants