Skip to content

Commit 0e70a97

Browse files
authored
Refactor Animated[List, Grid, SliverList, SliverGrid] to share common code (#113793)
1 parent 1cfdac4 commit 0e70a97

File tree

4 files changed

+672
-983
lines changed

4 files changed

+672
-983
lines changed

packages/flutter/lib/src/rendering/sliver_grid.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -462,9 +462,9 @@ class SliverGridDelegateWithMaxCrossAxisExtent extends SliverGridDelegate {
462462
SliverGridLayout getLayout(SliverConstraints constraints) {
463463
assert(_debugAssertIsValid(constraints.crossAxisExtent));
464464
int crossAxisCount = (constraints.crossAxisExtent / (maxCrossAxisExtent + crossAxisSpacing)).ceil();
465-
// TODO(gspencergoog): Figure out why we need this in release mode (and only
466-
// in release mode). https://github.com/flutter/flutter/issues/113109
467-
crossAxisCount = crossAxisCount < 1 ? 1 : crossAxisCount;
465+
// Ensure a minimum count of 1, can be zero and result in an infinite extent
466+
// below when the window size is 0.
467+
crossAxisCount = math.max(1, crossAxisCount);
468468
final double usableCrossAxisExtent = math.max(
469469
0.0,
470470
constraints.crossAxisExtent - crossAxisSpacing * (crossAxisCount - 1),

0 commit comments

Comments
 (0)