Skip to content

Commit 40bc6b5

Browse files
authored
Move debug error message from failed pub to logger.printTrace (#118379)
* Move debug error message from failed pub to logger.printTrace * Update test
1 parent 27502f6 commit 40bc6b5

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

packages/flutter_tools/lib/src/dart/pub.dart

+2-4
Original file line numberDiff line numberDiff line change
@@ -475,10 +475,8 @@ class _DefaultPub implements Pub {
475475
buffer.writeln('command: "${pubCommand.join(' ')}"');
476476
buffer.write(_stringifyPubEnv(pubEnvironment));
477477
buffer.writeln('exit code: $code');
478-
throwToolExit(
479-
buffer.toString(),
480-
exitCode: code,
481-
);
478+
_logger.printTrace(buffer.toString());
479+
throwToolExit(null, exitCode: code);
482480
}
483481
}
484482

packages/flutter_tools/test/general.shard/dart/pub_get_test.dart

+2-1
Original file line numberDiff line numberDiff line change
@@ -555,9 +555,10 @@ exit code: 66
555555
project: FlutterProject.fromDirectoryTest(fileSystem.currentDirectory),
556556
context: PubContext.flutterTests,
557557
),
558-
throwsA(isA<ToolExit>().having((ToolExit error) => error.message, 'message', toolExitMessage)),
558+
throwsA(isA<ToolExit>().having((ToolExit error) => error.message, 'message', null)),
559559
);
560560
expect(logger.statusText, isEmpty);
561+
expect(logger.traceText, contains(toolExitMessage));
561562
expect(
562563
mockStdio.stdout.writes.map(utf8.decode),
563564
<String>[

0 commit comments

Comments
 (0)