Skip to content

Commit 6b98f2c

Browse files
authored
labeledTapTargetGuideline should passe if textfield does not have label (#116221)
1 parent 9532b91 commit 6b98f2c

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

packages/flutter_test/lib/src/accessibility.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,8 @@ class LabeledTapTargetGuideline extends AccessibilityGuideline {
219219
});
220220
if (node.isMergedIntoParent ||
221221
node.isInvisible ||
222-
node.hasFlag(ui.SemanticsFlag.isHidden)) {
222+
node.hasFlag(ui.SemanticsFlag.isHidden) ||
223+
node.hasFlag(ui.SemanticsFlag.isTextField)) {
223224
return result;
224225
}
225226
final SemanticsData data = node.getSemanticsData();

packages/flutter_test/test/accessibility_test.dart

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -874,6 +874,14 @@ void main() {
874874
expect(result.passed, true);
875875
handle.dispose();
876876
});
877+
878+
testWidgets('Passes if text field does not have label', (WidgetTester tester) async {
879+
final SemanticsHandle handle = tester.ensureSemantics();
880+
await tester.pumpWidget(_boilerplate(const TextField()));
881+
final Evaluation result = await labeledTapTargetGuideline.evaluate(tester);
882+
expect(result.passed, true);
883+
handle.dispose();
884+
});
877885
});
878886

879887
testWidgets('regression test for material widget',

0 commit comments

Comments
 (0)