Skip to content

Commit 897ec59

Browse files
pqditman
andauthored
[ci] Removes unnecessary overrides. (#6669)
* remove unnecessary overrides * Update mock so tools_tests checks pass. * Update CHANGELOG NEXT entries. * Pin git to 2.0.x Co-authored-by: David Iglesias Teixeira <[email protected]>
1 parent 8cfa265 commit 897ec59

File tree

7 files changed

+238
-96
lines changed

7 files changed

+238
-96
lines changed

packages/video_player/video_player_android/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* Updates code for `no_leading_underscores_for_local_identifiers` lint.
44
* Updates minimum Flutter version to 2.10.
55
* Fixes violations of new analysis option use_named_constants.
6+
* Removes an unnecessary override in example code.
67

78
## 2.3.9
89

packages/video_player/video_player_android/example/lib/mini_controller.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -341,11 +341,6 @@ class MiniController extends ValueNotifier<VideoPlayerValue> {
341341
void _updatePosition(Duration position) {
342342
value = value.copyWith(position: position);
343343
}
344-
345-
@override
346-
void removeListener(VoidCallback listener) {
347-
super.removeListener(listener);
348-
}
349344
}
350345

351346
/// Widget that displays the video controlled by [controller].

packages/video_player/video_player_avfoundation/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## NEXT
22

33
* Adds an integration test for a bug where the aspect ratios of some HLS videos are incorrectly inverted.
4+
* Removes an unnecessary override in example code.
45

56
## 2.3.7
67

packages/video_player/video_player_avfoundation/example/lib/mini_controller.dart

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -341,11 +341,6 @@ class MiniController extends ValueNotifier<VideoPlayerValue> {
341341
void _updatePosition(Duration position) {
342342
value = value.copyWith(position: position);
343343
}
344-
345-
@override
346-
void removeListener(VoidCallback listener) {
347-
super.removeListener(listener);
348-
}
349344
}
350345

351346
/// Widget that displays the video controlled by [controller].

script/tool/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## NEXT
2+
3+
* Pins `package:git` dependency to `2.0.x` until `dart >=2.18.0` becomes our
4+
oldest legacy.
5+
* Updates test mocks.
6+
17
## 0.13.0
28

39
* Renames `all-plugins-app` to `create-all-packages-app` to clarify what it

script/tool/pubspec.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ dependencies:
99
collection: ^1.15.0
1010
colorize: ^3.0.0
1111
file: ^6.1.0
12-
git: ^2.0.0
12+
# Pin git to 2.0.x until dart >=2.18 is legacy
13+
git: '>=2.0.0 <2.1.0'
1314
http: ^0.13.3
1415
http_multi_server: ^3.0.1
1516
meta: ^1.3.0

0 commit comments

Comments
 (0)