Skip to content

Commit 906761c

Browse files
authored
Fix the message strings for xcodeMissing and xcodeIncomplete (#117922)
* Add macOS to xcodeMissing and xcodeIncomplete * And unit test
1 parent 63653e8 commit 906761c

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

packages/flutter_tools/lib/src/base/user_messages.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,10 @@ class UserMessages {
176176
'Launch Xcode and install additional required components when prompted or run:\n'
177177
' sudo xcodebuild -runFirstLaunch';
178178
String get xcodeMissing =>
179-
'Xcode not installed; this is necessary for iOS development.\n'
179+
'Xcode not installed; this is necessary for iOS and macOS development.\n'
180180
'Download at https://developer.apple.com/xcode/download/.';
181181
String get xcodeIncomplete =>
182-
'Xcode installation is incomplete; a full installation is necessary for iOS development.\n'
182+
'Xcode installation is incomplete; a full installation is necessary for iOS and macOS development.\n'
183183
'Download at: https://developer.apple.com/xcode/download/\n'
184184
'Or install Xcode via the App Store.\n'
185185
'Once installed, run:\n'

packages/flutter_tools/test/general.shard/base/user_messages_test.dart

+6
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,10 @@ void main() {
3030
checkInstallationURL((Platform platform) => userMessages.androidSdkBuildToolsOutdated(0, '', platform));
3131
checkInstallationURL((Platform platform) => userMessages.androidStudioInstallation(platform));
3232
});
33+
34+
testWithoutContext('Xcode installation instructions', () {
35+
final UserMessages userMessages = UserMessages();
36+
expect(userMessages.xcodeMissing, contains('iOS and macOS'));
37+
expect(userMessages.xcodeIncomplete, contains('iOS and macOS'));
38+
});
3339
}

0 commit comments

Comments
 (0)