Skip to content

Commit 9fb1ae8

Browse files
authored
[iOS] Add task for spell check integration test (#116222)
* Add fix and test * Add test owner * Print error for testing * Make sure locale is the problem * Test capitalization fix * Take out Android specific test * Verify eng fix * Test fix * Empty-Commit * Test all tests * Up string size for testing * Remove test * Undo ci.yaml testing changes * Test android variant: * Change to testwidgets * Add widget tester * Remove android only attempt * Revert ci.yaml changes
1 parent ca7ca3b commit 9fb1ae8

File tree

4 files changed

+14
-23
lines changed

4 files changed

+14
-23
lines changed

.ci.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3895,7 +3895,7 @@ targets:
38953895
properties:
38963896
tags: >
38973897
["devicelab", "ios", "mac"]
3898-
task_name: spell_check_test
3898+
task_name: spell_check_test_ios
38993899

39003900
- name: Mac native_ui_tests_macos
39013901
recipe: devicelab/devicelab_drone

TESTOWNERS

+1
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,7 @@
259259
/dev/devicelab/bin/tasks/web_benchmarks_html.dart @yjbanov @flutter/web
260260
/dev/devicelab/bin/tasks/windows_home_scroll_perf__timeline_summary.dart @jonahwilliams @flutter/engine
261261
/dev/devicelab/bin/tasks/windows_startup_test.dart @loic-sharma @flutter/desktop
262+
/dev/devicelab/bin/tasks/spell_check_test_ios.dart @camsim99 @flutter/android
262263

263264
## Host only framework tests
264265
# Linux analyze
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
// Copyright 2014 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:flutter_devicelab/framework/devices.dart';
6+
import 'package:flutter_devicelab/framework/framework.dart';
7+
import 'package:flutter_devicelab/tasks/integration_tests.dart';
8+
9+
Future<void> main() async {
10+
deviceOperatingSystem = DeviceOperatingSystem.ios;
11+
await task(createSpellCheckIntegrationTest());
12+
}

dev/integration_tests/spell_check/integration_test/integration_test.dart

-22
Original file line numberDiff line numberDiff line change
@@ -176,26 +176,4 @@ void main() {
176176

177177
expect(expectedTextSpanTreeFound, isTrue);
178178
});
179-
180-
test(
181-
'fetchSpellCheckSuggestions returns null when there is a pending request',
182-
() async {
183-
final String text =
184-
'neaf niofenaifn iofn iefnaoeifn ifneoa finoiafn inf ionfieaon ienf ifn ieonfaiofneionf oieafn oifnaioe nioenfio nefaion oifan' *
185-
10;
186-
187-
defaultSpellCheckService.fetchSpellCheckSuggestions(locale, text);
188-
189-
final String modifiedText = text.substring(5);
190-
191-
final List<SuggestionSpan>? spellCheckSuggestionSpans =
192-
await defaultSpellCheckService.fetchSpellCheckSuggestions(
193-
locale, modifiedText);
194-
195-
expect(spellCheckSuggestionSpans, isNull);
196-
197-
// We expect it to be rare for the first request to complete before the
198-
// second, so no text should be saved as of now.
199-
expect(defaultSpellCheckService.lastSavedResults, null);
200-
});
201179
}

0 commit comments

Comments
 (0)