Skip to content

Commit a124e08

Browse files
Try returning to runInShell:true to see if that fixes the CI hang
1 parent 3b31169 commit a124e08

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

packages/pigeon/tool/run_tests.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,9 @@ Future<int> _runMockHandlerTests() async {
239239

240240
Future<int> _runWindowsUnitTests() async {
241241
const String examplePath = './$testPluginRelativePath/example';
242-
final int compileCode = await runFlutterBuild(examplePath, 'windows');
242+
final int compileCode = await runProcess(
243+
'flutter', <String>['build', 'windows', '--debug'],
244+
workingDirectory: examplePath, runInShell: true);
243245
if (compileCode != 0) {
244246
return compileCode;
245247
}

packages/pigeon/tool/shared/process_utils.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@ Future<Process> _streamOutput(Future<Process> processFuture) async {
1414
Future<int> runProcess(String command, List<String> arguments,
1515
{String? workingDirectory,
1616
bool streamOutput = true,
17-
bool logFailure = false}) async {
17+
bool logFailure = false,
18+
bool runInShell = false}) async {
1819
final Future<Process> future = Process.start(
1920
command,
2021
arguments,
2122
workingDirectory: workingDirectory,
23+
runInShell: runInShell,
2224
);
2325
final Process process = await (streamOutput ? _streamOutput(future) : future);
2426
final int exitCode = await process.exitCode;

0 commit comments

Comments
 (0)