Skip to content

Commit a440c46

Browse files
Do not assume that pub is the first command run by "flutter create" (#114621)
The "flutter create" command on macOS may run other commands such as openssl when it calls _getCodeSigningIdentityDevelopmentTeam
1 parent 0943693 commit a440c46

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

packages/flutter_tools/test/commands.shard/permeable/create_test.dart

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1921,14 +1921,17 @@ void main() {
19211921

19221922
// Run pub online first in order to populate the pub cache.
19231923
await runner.run(<String>['create', '--pub', projectDir.path]);
1924-
expect(loggingProcessManager.commands.first, contains(matches(r'dart-sdk[\\/]bin[\\/]dart')));
1925-
expect(loggingProcessManager.commands.first, isNot(contains('--offline')));
1924+
final RegExp dartCommand = RegExp(r'dart-sdk[\\/]bin[\\/]dart');
1925+
expect(loggingProcessManager.commands, contains(predicate(
1926+
(List<String> c) => dartCommand.hasMatch(c[0]) && c[1].contains('pub') && !c.contains('--offline')
1927+
)));
19261928

19271929
// Run pub offline.
19281930
loggingProcessManager.clear();
19291931
await runner.run(<String>['create', '--pub', '--offline', projectDir.path]);
1930-
expect(loggingProcessManager.commands.first, contains(matches(r'dart-sdk[\\/]bin[\\/]dart')));
1931-
expect(loggingProcessManager.commands.first, contains('--offline'));
1932+
expect(loggingProcessManager.commands, contains(predicate(
1933+
(List<String> c) => dartCommand.hasMatch(c[0]) && c[1].contains('pub') && c.contains('--offline')
1934+
)));
19321935
},
19331936
overrides: <Type, Generator>{
19341937
ProcessManager: () => loggingProcessManager,

0 commit comments

Comments
 (0)