Skip to content

Commit c7cb5f3

Browse files
[flutter_tools] pin package intl and roll pub packages (#117168)
* pin package intl and roll pub packages * add test * fix analysis
1 parent a34e419 commit c7cb5f3

File tree

5 files changed

+27
-13
lines changed

5 files changed

+27
-13
lines changed

dev/integration_tests/gradle_deprecated_settings/pubspec.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ environment:
77
dependencies:
88
flutter:
99
sdk: flutter
10-
camera: 0.10.0+4
10+
camera: 0.10.0+5
1111

1212
camera_android: 0.10.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
1313
camera_avfoundation: 0.9.9 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
@@ -31,4 +31,4 @@ dependencies:
3131
flutter:
3232
uses-material-design: true
3333

34-
# PUBSPEC CHECKSUM: 7ef1
34+
# PUBSPEC CHECKSUM: 6cf2

packages/flutter_tools/lib/src/commands/update_packages.dart

+2
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ const Map<String, String> kManuallyPinnedDependencies = <String, String>{
4141
'archive': '3.3.2',
4242
// https://github.com/flutter/flutter/issues/116376
4343
'path_provider_android': '2.0.21',
44+
// https://github.com/flutter/flutter/issues/117163
45+
'intl': '0.17.0',
4446
};
4547

4648
class UpdatePackagesCommand extends FlutterCommand {

packages/flutter_tools/pubspec.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ dependencies:
1212
browser_launcher: 1.1.1
1313
dds: 2.5.0
1414
dwds: 16.0.1
15-
completion: 1.0.0
15+
completion: 1.0.1
1616
coverage: 1.6.1
1717
crypto: 3.0.2
1818
file: 6.1.4
@@ -102,4 +102,4 @@ dartdoc:
102102
# Exclude this package from the hosted API docs.
103103
nodoc: true
104104

105-
# PUBSPEC CHECKSUM: 1fee
105+
# PUBSPEC CHECKSUM: 59ef

packages/flutter_tools/test/commands.shard/hermetic/update_packages_test.dart

-9
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import 'package:flutter_tools/src/project.dart';
1313
import 'package:test/fake.dart';
1414
import 'package:yaml/yaml.dart';
1515

16-
import '../../src/common.dart';
1716
import '../../src/context.dart';
1817
import '../../src/test_flutter_command_runner.dart';
1918

@@ -75,14 +74,6 @@ dependencies:
7574
''';
7675

7776
void main() {
78-
testWithoutContext('kManuallyPinnedDependencies pins are actually pins', () {
79-
expect(
80-
kManuallyPinnedDependencies.values,
81-
isNot(contains(anyOf('any', startsWith('^'), startsWith('>'), startsWith('<')))),
82-
reason: 'Version pins in kManuallyPinnedDependencies must be specific pins, not ranges.',
83-
);
84-
});
85-
8677
group('update-packages', () {
8778
late FileSystem fileSystem;
8879
late Directory flutterSdk;

packages/flutter_tools/test/general.shard/update_packages_test.dart

+21
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,27 @@ void main() {
9393
flutter.childFile('pubspec.yaml').writeAsStringSync(kFlutterPubspecYaml);
9494
});
9595

96+
testWithoutContext('kManuallyPinnedDependencies pins are actually pins', () {
97+
expect(
98+
kManuallyPinnedDependencies.values,
99+
isNot(contains(anyOf('any', startsWith('^'), startsWith('>'), startsWith('<')))),
100+
reason: 'Version pins in kManuallyPinnedDependencies must be specific pins, not ranges.',
101+
);
102+
expect(
103+
kManuallyPinnedDependencies.keys,
104+
unorderedEquals(const <String>[
105+
'flutter_gallery_assets',
106+
'flutter_template_images',
107+
'video_player',
108+
'material_color_utilities',
109+
'url_launcher_android',
110+
'archive',
111+
'path_provider_android',
112+
'intl',
113+
]),
114+
);
115+
});
116+
96117
testWithoutContext(
97118
'createTemporaryFlutterSdk creates an unpinned flutter SDK', () {
98119
// A stray extra package should not cause a crash.

0 commit comments

Comments
 (0)