Skip to content

Commit fbe9ff3

Browse files
Disable an inaccurate test assertion that will be fixed by an engine roll (#119653)
https://skia-review.googlesource.com/c/skia/+/619838 fixes a bug in SkParagraph. One of the selectable region tests relies on the old behavior. After that Skia change rolls into the framework, the update to the test in flutter/flutter#118902 should be landed.
1 parent 60c1f29 commit fbe9ff3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

packages/flutter/test/widgets/selectable_region_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,8 @@ void main() {
842842
// Add a little offset to cross the boundary between paragraph 2 and 3.
843843
await gesture.moveTo(textOffsetToPosition(paragraph3, 6) + const Offset(0, 1));
844844
expect(paragraph1.selections[0], const TextSelection(baseOffset: 2, extentOffset: 12));
845-
expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 8));
845+
// TODO(jsimmons): reenable this with updated expectations after https://skia-review.googlesource.com/c/skia/+/619838 lands
846+
//expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 8));
846847
expect(paragraph3.selections[0], const TextSelection(baseOffset: 0, extentOffset: 6));
847848

848849
await gesture.up();

0 commit comments

Comments
 (0)