[camera]add unit test for flash mode related functions

Author: hellohuanlin

packages/camera/camera/CHANGELOG.md

@@ -1,7 +1,11 @@
+## NEXT
+
+* Minor iOS internal code cleanup related to flash mode. 
+
 ## 0.9.4+7
 
 * Fixes a crash in iOS when passing null queue pointer into AVFoundation API due to race condition.  
-* Minor iOS internal code cleanup.
+* Minor iOS internal code cleanup related to dispatch queue.
 
 ## 0.9.4+6
 

packages/camera/camera/example/ios/Runner.xcodeproj/project.pbxproj

@@ -22,6 +22,7 @@
 		97C147011CF9000F007C117D /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 97C146FF1CF9000F007C117D /* LaunchScreen.storyboard */; };
 		E01EE4A82799F3A5008C1950 /* QueueHelperTests.m in Sources */ = {isa = PBXBuildFile; fileRef = E01EE4A72799F3A5008C1950 /* QueueHelperTests.m */; };
 		E032F250279F5E94009E9028 /* CameraCaptureSessionQueueRaceConditionTests.m in Sources */ = {isa = PBXBuildFile; fileRef = E032F24F279F5E94009E9028 /* CameraCaptureSessionQueueRaceConditionTests.m */; };
+		E032F2A727A0BF2D009E9028 /* FlashModeTests.m in Sources */ = {isa = PBXBuildFile; fileRef = E032F2A627A0BF2D009E9028 /* FlashModeTests.m */; };
 		E0C6E2002770F01A00EA6AA3 /* ThreadSafeMethodChannelTests.m in Sources */ = {isa = PBXBuildFile; fileRef = E0C6E1FD2770F01A00EA6AA3 /* ThreadSafeMethodChannelTests.m */; };
 		E0C6E2012770F01A00EA6AA3 /* ThreadSafeTextureRegistryTests.m in Sources */ = {isa = PBXBuildFile; fileRef = E0C6E1FE2770F01A00EA6AA3 /* ThreadSafeTextureRegistryTests.m */; };
 		E0C6E2022770F01A00EA6AA3 /* ThreadSafeEventChannelTests.m in Sources */ = {isa = PBXBuildFile; fileRef = E0C6E1FF2770F01A00EA6AA3 /* ThreadSafeEventChannelTests.m */; };
@@ -81,6 +82,7 @@
 		A24F9E418BA48BCC7409B117 /* Pods-RunnerTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-RunnerTests.release.xcconfig"; path = "Target Support Files/Pods-RunnerTests/Pods-RunnerTests.release.xcconfig"; sourceTree = "<group>"; };
 		E01EE4A72799F3A5008C1950 /* QueueHelperTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = QueueHelperTests.m; sourceTree = "<group>"; };
 		E032F24F279F5E94009E9028 /* CameraCaptureSessionQueueRaceConditionTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = CameraCaptureSessionQueueRaceConditionTests.m; sourceTree = "<group>"; };
+		E032F2A627A0BF2D009E9028 /* FlashModeTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = FlashModeTests.m; sourceTree = "<group>"; };
 		E0C6E1FD2770F01A00EA6AA3 /* ThreadSafeMethodChannelTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ThreadSafeMethodChannelTests.m; sourceTree = "<group>"; };
 		E0C6E1FE2770F01A00EA6AA3 /* ThreadSafeTextureRegistryTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ThreadSafeTextureRegistryTests.m; sourceTree = "<group>"; };
 		E0C6E1FF2770F01A00EA6AA3 /* ThreadSafeEventChannelTests.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = ThreadSafeEventChannelTests.m; sourceTree = "<group>"; };
@@ -125,6 +127,7 @@
 				F6EE622E2710A6FC00905E4A /* MockFLTThreadSafeFlutterResult.m */,
 				F63F9EED27143B19002479BF /* MockFLTThreadSafeFlutterResult.h */,
 				E032F24F279F5E94009E9028 /* CameraCaptureSessionQueueRaceConditionTests.m */,
+				E032F2A627A0BF2D009E9028 /* FlashModeTests.m */,
 			);
 			path = RunnerTests;
 			sourceTree = "<group>";
@@ -388,6 +391,7 @@
 			buildActionMask = 2147483647;
 			files = (
 				03F6F8B226CBB4670024B8D3 /* ThreadSafeFlutterResultTests.m in Sources */,
+				E032F2A727A0BF2D009E9028 /* FlashModeTests.m in Sources */,
 				033B94BE269C40A200B4DF97 /* CameraMethodChannelTests.m in Sources */,
 				03BB766B2665316900CE5A93 /* CameraFocusTests.m in Sources */,
 				E487C86026D686A10034AC92 /* CameraPreviewPauseTests.m in Sources */,

packages/camera/camera/example/ios/RunnerTests/FlashModeTests.m

@@ -0,0 +1,29 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <XCTest/XCTest.h>
+#import "FlashMode.h"
+
+@interface FlashModeTests : XCTestCase
+
+@end
+
+@implementation FlashModeTests
+
+- (void)testGetFlashModeForString {
+  XCTAssertEqual(FlashModeOff, getFlashModeForString(@"off"));
+  XCTAssertEqual(FlashModeAuto, getFlashModeForString(@"auto"));
+  XCTAssertEqual(FlashModeAlways, getFlashModeForString(@"always"));
+  XCTAssertEqual(FlashModeTorch, getFlashModeForString(@"torch"));
+  XCTAssertThrows(getFlashModeForString(@"unkwown"));
+}
+
+- (void)testGetAVCaptureFlashModeForFlashMode {
+  XCTAssertEqual(AVCaptureFlashModeOff, getAVCaptureFlashModeForFlashMode(FlashModeOff));
+  XCTAssertEqual(AVCaptureFlashModeAuto, getAVCaptureFlashModeForFlashMode(FlashModeAuto));
+  XCTAssertEqual(AVCaptureFlashModeOn, getAVCaptureFlashModeForFlashMode(FlashModeAlways));
+  XCTAssertEqual(-1, getAVCaptureFlashModeForFlashMode(FlashModeTorch));
+}
+
+@end

packages/camera/camera/ios/Classes/CameraPlugin.m

@@ -10,11 +10,11 @@
 #import <CoreMotion/CoreMotion.h>
 #import <libkern/OSAtomic.h>
 #import <uuid/uuid.h>
-#import "FlashMode.h"
 #import "FLTThreadSafeEventChannel.h"
 #import "FLTThreadSafeFlutterResult.h"
 #import "FLTThreadSafeMethodChannel.h"
 #import "FLTThreadSafeTextureRegistry.h"
+#import "FlashMode.h"
 
 @interface FLTSavePhotoDelegate : NSObject <AVCapturePhotoCaptureDelegate>
 @property(readonly, nonatomic) NSString *path;

packages/camera/camera/ios/Classes/FlashMode.h

@@ -10,15 +10,26 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
-// Mirrors FlashMode in flash_mode.dart
+/**
+ * Represents camera's flash mode. Mirrors `FlashMode` enum in flash_mode.dart.
+ */
 typedef enum {
   FlashModeOff,
   FlashModeAuto,
   FlashModeAlways,
   FlashModeTorch,
 } FlashMode;
 
+/**
+ * Gets FlashMode from its string representation.
+ * @param mode a string representation of the FlashMode.
+ */
 FlashMode getFlashModeForString(NSString *mode);
+
+/**
+ * Gets AVCaptureFlashMode from FlashMode.
+ * @param mode flash mode.
+ */
 AVCaptureFlashMode getAVCaptureFlashModeForFlashMode(FlashMode mode);
 
 NS_ASSUME_NONNULL_END

packages/camera/camera/ios/Classes/FlashMode.m

@@ -40,4 +40,3 @@ AVCaptureFlashMode getAVCaptureFlashModeForFlashMode(FlashMode mode) {
       return -1;
   }
 }
-

packages/camera/camera/ios/Classes/camera-umbrella.h

@@ -8,6 +8,7 @@
 #import <camera/FLTThreadSafeFlutterResult.h>
 #import <camera/FLTThreadSafeMethodChannel.h>
 #import <camera/FLTThreadSafeTextureRegistry.h>
+#import <camera/FlashMode.h>
 #import <camera/QueueHelper.h>
 
 FOUNDATION_EXPORT double cameraVersionNumber;