Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 2e8fb33

Browse files
committed
[google_sign_in] Upgrade to GoogleSignIn 6.2, suport arm64 simulators
1 parent 053c4bd commit 2e8fb33

File tree

10 files changed

+448
-252
lines changed

10 files changed

+448
-252
lines changed

packages/google_sign_in/google_sign_in/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
* Updates tests to use a mock platform instead of relying on default
44
method channel implementation internals.
5+
* Removes example workaround to build for arm64 iOS simulators.
56

67
## 5.3.1
78

packages/google_sign_in/google_sign_in/example/ios/Podfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,5 @@ end
3434
post_install do |installer|
3535
installer.pods_project.targets.each do |target|
3636
flutter_additional_ios_build_settings(target)
37-
target.build_configurations.each do |build_configuration|
38-
# GoogleSignIn does not support arm64 simulators.
39-
build_configuration.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64 i386'
40-
end
4137
end
4238
end

packages/google_sign_in/google_sign_in/example/ios/Runner.xcodeproj/project.pbxproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,6 @@
426426
buildSettings = {
427427
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
428428
ENABLE_BITCODE = NO;
429-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
430429
FRAMEWORK_SEARCH_PATHS = (
431430
"$(inherited)",
432431
"$(PROJECT_DIR)/Flutter",
@@ -448,7 +447,6 @@
448447
buildSettings = {
449448
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
450449
ENABLE_BITCODE = NO;
451-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
452450
FRAMEWORK_SEARCH_PATHS = (
453451
"$(inherited)",
454452
"$(PROJECT_DIR)/Flutter",

packages/google_sign_in/google_sign_in_ios/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 5.3.0
2+
3+
* Supports arm64 iOS simulators by increasing GoogleSignIn dependency to version 6.2.
4+
15
## 5.2.7
26

37
* Fixes library_private_types_in_public_api, sort_child_properties_last and use_key_in_widget_constructors

packages/google_sign_in/google_sign_in_ios/example/ios/Podfile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ require File.expand_path(File.join('packages', 'flutter_tools', 'bin', 'podhelpe
2828
flutter_ios_podfile_setup
2929

3030
target 'Runner' do
31+
pod 'GoogleSignIn', :git => 'https://github.com/google/GoogleSignIn-iOS.git', :commit => '0dc783f36577f5bc249056f835d592ffae59d0ee'
32+
3133
flutter_install_all_ios_pods File.dirname(File.realpath(__FILE__))
3234
target 'RunnerTests' do
3335
inherit! :search_paths
@@ -39,9 +41,5 @@ end
3941
post_install do |installer|
4042
installer.pods_project.targets.each do |target|
4143
flutter_additional_ios_build_settings(target)
42-
target.build_configurations.each do |build_configuration|
43-
# GoogleSignIn does not support arm64 simulators.
44-
build_configuration.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64 i386'
45-
end
4644
end
4745
end

packages/google_sign_in/google_sign_in_ios/example/ios/Runner.xcodeproj/project.pbxproj

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@
384384
);
385385
inputPaths = (
386386
"${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-resources.sh",
387-
"${PODS_ROOT}/GoogleSignIn/Resources/GoogleSignIn.bundle",
387+
"${PODS_CONFIGURATION_BUILD_DIR}/GoogleSignIn/GoogleSignIn.bundle",
388388
);
389389
name = "[CP] Copy Pods Resources";
390390
outputPaths = (
@@ -603,7 +603,6 @@
603603
buildSettings = {
604604
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
605605
ENABLE_BITCODE = NO;
606-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
607606
FRAMEWORK_SEARCH_PATHS = (
608607
"$(inherited)",
609608
"$(PROJECT_DIR)/Flutter",
@@ -625,7 +624,6 @@
625624
buildSettings = {
626625
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
627626
ENABLE_BITCODE = NO;
628-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
629627
FRAMEWORK_SEARCH_PATHS = (
630628
"$(inherited)",
631629
"$(PROJECT_DIR)/Flutter",
@@ -647,7 +645,6 @@
647645
buildSettings = {
648646
BUNDLE_LOADER = "$(TEST_HOST)";
649647
CODE_SIGN_STYLE = Automatic;
650-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
651648
INFOPLIST_FILE = RunnerTests/Info.plist;
652649
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
653650
PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;
@@ -662,7 +659,6 @@
662659
buildSettings = {
663660
BUNDLE_LOADER = "$(TEST_HOST)";
664661
CODE_SIGN_STYLE = Automatic;
665-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
666662
INFOPLIST_FILE = RunnerTests/Info.plist;
667663
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
668664
PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;

0 commit comments

Comments
 (0)