Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 33b81ed

Browse files
authored
fixes for incoming linter (#113794)
* fixes for incomming linter * + todo * todo format fix * justify ignore * --
1 parent a440c46 commit 33b81ed

File tree

4 files changed

+4
-10
lines changed

4 files changed

+4
-10
lines changed

packages/flutter/lib/src/material/menu_anchor.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,7 @@ class _MenuAnchorState extends State<MenuAnchor> {
483483
// close it first.
484484
_close();
485485
}
486-
assert(_debugMenuInfo('Opening ${this} at ${position ?? Offset.zero} with alignment offset ${widget.alignmentOffset ?? Offset.zero}'));
486+
assert(_debugMenuInfo('Opening $this at ${position ?? Offset.zero} with alignment offset ${widget.alignmentOffset ?? Offset.zero}'));
487487
_parent?._closeChildren(); // Close all siblings.
488488
assert(_overlayEntry == null);
489489

@@ -553,6 +553,8 @@ class _MenuAnchorState extends State<MenuAnchor> {
553553
}
554554

555555
void _closeChildren({bool inDispose = false}) {
556+
// TODO(pquitslund): remove when interpolated `$this` parsing is fixed (https://github.com/dart-lang/sdk/issues/50263)
557+
// ignore: unnecessary_brace_in_string_interps
556558
assert(_debugMenuInfo('Closing children of ${this}${inDispose ? ' (dispose)' : ''}'));
557559
for (final _MenuAnchorState child in List<_MenuAnchorState>.from(_anchorChildren)) {
558560
child._close(inDispose: inDispose);

packages/flutter/lib/src/widgets/layout_builder.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,6 @@ class LayoutBuilder extends ConstrainedLayoutBuilder<BoxConstraints> {
269269
required super.builder,
270270
}) : assert(builder != null);
271271

272-
@override
273-
LayoutWidgetBuilder get builder => super.builder;
274-
275272
@override
276273
RenderObject createRenderObject(BuildContext context) => _RenderLayoutBuilder();
277274
}

packages/flutter/lib/src/widgets/sliver_layout_builder.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,6 @@ class SliverLayoutBuilder extends ConstrainedLayoutBuilder<SliverConstraints> {
3232
required super.builder,
3333
});
3434

35-
/// Called at layout time to construct the widget tree.
36-
///
37-
/// The builder must return a non-null sliver widget.
38-
@override
39-
SliverLayoutWidgetBuilder get builder => super.builder;
40-
4135
@override
4236
RenderObject createRenderObject(BuildContext context) => _RenderSliverLayoutBuilder();
4337
}

packages/flutter_test/lib/src/test_compat.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ Declarer get _declarer {
3434
Future<void>(() {
3535
Invoker.guard<Future<void>>(() async {
3636
final _Reporter reporter = _Reporter(color: false); // disable color when run directly.
37+
// ignore: recursive_getters, this self-call is safe since it will just fetch the declarer instance
3738
final Group group = _declarer.build();
3839
final Suite suite = Suite(group, SuitePlatform(Runtime.vm));
3940
await _runGroup(suite, group, <Group>[], reporter);

0 commit comments

Comments
 (0)