Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 42287a4

Browse files
committed
Added tests to assert when LifecycleObserver is implemented.
1 parent 5d9510a commit 42287a4

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/CameraTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
package io.flutter.plugins.camera;
66

77
import static org.junit.Assert.assertEquals;
8+
import static org.junit.Assert.assertFalse;
89
import static org.junit.Assert.assertNotNull;
910
import static org.mockito.ArgumentMatchers.any;
1011
import static org.mockito.ArgumentMatchers.eq;
@@ -27,6 +28,7 @@
2728
import android.os.Handler;
2829
import android.os.HandlerThread;
2930
import androidx.annotation.NonNull;
31+
import androidx.lifecycle.LifecycleObserver;
3032
import io.flutter.embedding.engine.systemchannels.PlatformChannel;
3133
import io.flutter.plugin.common.MethodChannel;
3234
import io.flutter.plugins.camera.features.CameraFeatureFactory;
@@ -112,6 +114,13 @@ public void after() {
112114
mockHandlerFactory.close();
113115
}
114116

117+
@Test
118+
public void shouldNotImplementLifecycleObserverInterface() {
119+
Class<Camera> cameraClass = Camera.class;
120+
121+
assertFalse(LifecycleObserver.class.isAssignableFrom(cameraClass));
122+
}
123+
115124
@Test
116125
public void shouldCreateCameraPluginAndSetAllFeatures() {
117126
final Activity mockActivity = mock(Activity.class);

packages/camera/camera/android/src/test/java/io/flutter/plugins/camera/MethodCallHandlerImplTest.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@
44

55
package io.flutter.plugins.camera;
66

7+
import static org.junit.Assert.assertFalse;
78
import static org.mockito.Mockito.doThrow;
89
import static org.mockito.Mockito.mock;
910
import static org.mockito.Mockito.times;
1011
import static org.mockito.Mockito.verify;
1112

1213
import android.app.Activity;
1314
import android.hardware.camera2.CameraAccessException;
15+
import androidx.lifecycle.LifecycleObserver;
1416
import io.flutter.plugin.common.BinaryMessenger;
1517
import io.flutter.plugin.common.MethodCall;
1618
import io.flutter.plugin.common.MethodChannel;
@@ -39,6 +41,13 @@ public void setUp() {
3941
TestUtils.setPrivateField(handler, "camera", mockCamera);
4042
}
4143

44+
@Test
45+
public void shouldNotImplementLifecycleObserverInterface() {
46+
Class<MethodCallHandlerImpl> methodCallHandlerClass = MethodCallHandlerImpl.class;
47+
48+
assertFalse(LifecycleObserver.class.isAssignableFrom(methodCallHandlerClass));
49+
}
50+
4251
@Test
4352
public void onMethodCall_pausePreview_shouldPausePreviewAndSendSuccessResult()
4453
throws CameraAccessException {

0 commit comments

Comments
 (0)