Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 64d8ae8

Browse files
committed
[google_sign_in] Remove unused variable
1 parent 6ccebda commit 64d8ae8

File tree

3 files changed

+87
-84
lines changed

3 files changed

+87
-84
lines changed
Lines changed: 86 additions & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -1,120 +1,124 @@
1+
## 4.1.5
2+
3+
- Remove unused variable.
4+
15
## 4.1.4
26

3-
* Make the pedantic dev_dependency explicit.
7+
- Make the pedantic dev_dependency explicit.
48

59
## 4.1.3
610

7-
* Make plugin example meet naming convention.
11+
- Make plugin example meet naming convention.
812

913
## 4.1.2
1014

11-
* Added a new error code `network_error`, and return it when a network error occurred.
15+
- Added a new error code `network_error`, and return it when a network error occurred.
1216

1317
## 4.1.1
1418

15-
* Support passing `clientId` to the web plugin programmatically.
19+
- Support passing `clientId` to the web plugin programmatically.
1620

1721
## 4.1.0
1822

19-
* Support web by default.
20-
* Require Flutter SDK `v1.12.13+hotfix.4` or greater.
23+
- Support web by default.
24+
- Require Flutter SDK `v1.12.13+hotfix.4` or greater.
2125

2226
## 4.0.17
2327

24-
* Add missing documentation and fix an unawaited future in the example app.
28+
- Add missing documentation and fix an unawaited future in the example app.
2529

2630
## 4.0.16
2731

28-
* Remove the deprecated `author:` field from pubspec.yaml
29-
* Migrate the plugin to the pubspec platforms manifest.
30-
* Require Flutter SDK 1.10.0 or greater.
32+
- Remove the deprecated `author:` field from pubspec.yaml
33+
- Migrate the plugin to the pubspec platforms manifest.
34+
- Require Flutter SDK 1.10.0 or greater.
3135

3236
## 4.0.15
3337

34-
* Export SignInOption from interface since it is used in the frontend as a type.
38+
- Export SignInOption from interface since it is used in the frontend as a type.
3539

3640
## 4.0.14
3741

38-
* Port plugin code to use the federated Platform Interface, instead of a MethodChannel directly.
42+
- Port plugin code to use the federated Platform Interface, instead of a MethodChannel directly.
3943

4044
## 4.0.13
4145

42-
* Fix `GoogleUserCircleAvatar` to handle new style profile image URLs.
46+
- Fix `GoogleUserCircleAvatar` to handle new style profile image URLs.
4347

4448
## 4.0.12
4549

46-
* Move google_sign_in plugin to google_sign_in/google_sign_in to prepare for federated implementations.
50+
- Move google_sign_in plugin to google_sign_in/google_sign_in to prepare for federated implementations.
4751

4852
## 4.0.11
4953

50-
* Update iOS CocoaPod dependency to 5.0 to fix deprecated API usage issue.
54+
- Update iOS CocoaPod dependency to 5.0 to fix deprecated API usage issue.
5155

5256
## 4.0.10
5357

54-
* Remove AndroidX warning.
58+
- Remove AndroidX warning.
5559

5660
## 4.0.9
5761

58-
* Update and migrate iOS example project.
59-
* Define clang module for iOS.
62+
- Update and migrate iOS example project.
63+
- Define clang module for iOS.
6064

6165
## 4.0.8
6266

63-
* Get rid of `MethodCompleter` and serialize async actions using chained futures.
67+
- Get rid of `MethodCompleter` and serialize async actions using chained futures.
6468
This prevents a bug when sign in methods are being used in error handling zones.
6569

6670
## 4.0.7
6771

68-
* Switch from using `api` to `implementation` for dependency on `play-services-auth`,
72+
- Switch from using `api` to `implementation` for dependency on `play-services-auth`,
6973
preventing version mismatch build failures in some Android configurations.
7074

7175
## 4.0.6
7276

73-
* Fixed the `PlatformException` leaking from `catchError()` in debug mode.
77+
- Fixed the `PlatformException` leaking from `catchError()` in debug mode.
7478

7579
## 4.0.5
7680

77-
* Update README with solution to `APIException` errors.
81+
- Update README with solution to `APIException` errors.
7882

7983
## 4.0.4
8084

81-
* Revert changes in 4.0.3.
85+
- Revert changes in 4.0.3.
8286

8387
## 4.0.3
8488

85-
* Update guava to `27.0.1-android`.
86-
* Add correct @NonNull annotations to reduce compiler warnings.
89+
- Update guava to `27.0.1-android`.
90+
- Add correct @NonNull annotations to reduce compiler warnings.
8791

8892
## 4.0.2
8993

90-
* Add missing template type parameter to `invokeMethod` calls.
91-
* Bump minimum Flutter version to 1.5.0.
92-
* Replace invokeMethod with invokeMapMethod wherever necessary.
94+
- Add missing template type parameter to `invokeMethod` calls.
95+
- Bump minimum Flutter version to 1.5.0.
96+
- Replace invokeMethod with invokeMapMethod wherever necessary.
9397

9498
## 4.0.1+3
9599

96-
* Update example to gracefully handle null user information.
100+
- Update example to gracefully handle null user information.
97101

98102
## 4.0.1+2
99103

100-
* Fix README.md to correctly spell `GoogleService-Info.plist`.
104+
- Fix README.md to correctly spell `GoogleService-Info.plist`.
101105

102106
## 4.0.1+1
103107

104-
* Remove categories.
108+
- Remove categories.
105109

106110
## 4.0.1
107111

108-
* Log a more detailed warning at build time about the previous AndroidX
112+
- Log a more detailed warning at build time about the previous AndroidX
109113
migration.
110114

111115
## 4.0.0+1
112116

113-
* Added a better error message for iOS when the app is missing necessary URL schemes.
117+
- Added a better error message for iOS when the app is missing necessary URL schemes.
114118

115119
## 4.0.0
116120

117-
* **Breaking change**. Migrate from the deprecated original Android Support
121+
- **Breaking change**. Migrate from the deprecated original Android Support
118122
Library to AndroidX. This shouldn't result in any functional changes, but it
119123
requires any Android apps using this plugin to [also
120124
migrate](https://developer.android.com/jetpack/androidx/migrate) if they're
@@ -124,7 +128,7 @@
124128

125129
## 3.3.0+1
126130

127-
* **Revert the breaking 3.3.0 update**. 3.3.0 was known to be breaking and
131+
- **Revert the breaking 3.3.0 update**. 3.3.0 was known to be breaking and
128132
should have incremented the major version number instead of the minor. This
129133
revert is in and of itself breaking for anyone that has already migrated
130134
however. Anyone who has already migrated their app to AndroidX should
@@ -133,136 +137,137 @@
133137

134138
## 3.3.0
135139

136-
* **BAD**. This was a breaking change that was incorrectly published on a minor
140+
- **BAD**. This was a breaking change that was incorrectly published on a minor
137141
version upgrade, should never have happened. Reverted by 3.3.0+1.
138142

139-
* **Breaking change**. Migrate from the deprecated original Android Support
143+
- **Breaking change**. Migrate from the deprecated original Android Support
140144
Library to AndroidX. This shouldn't result in any functional changes, but it
141145
requires any Android apps using this plugin to [also
142146
migrate](https://developer.android.com/jetpack/androidx/migrate) if they're
143147
using the original support library.
144148

145149
## 3.2.4
146150

147-
* Increase play-services-auth version to 16.0.1
151+
- Increase play-services-auth version to 16.0.1
148152

149153
## 3.2.3
150154

151-
* Change google-services.json and GoogleService-Info.plist of example.
155+
- Change google-services.json and GoogleService-Info.plist of example.
152156

153157
## 3.2.2
154158

155-
* Don't use the result code when handling signin. This results in better error codes because result code always returns "cancelled".
159+
- Don't use the result code when handling signin. This results in better error codes because result code always returns "cancelled".
156160

157161
## 3.2.1
158162

159-
* Set http version to be compatible with flutter_test.
163+
- Set http version to be compatible with flutter_test.
160164

161165
## 3.2.0
162166

163-
* Add support for clearing authentication cache for Android.
167+
- Add support for clearing authentication cache for Android.
164168

165169
## 3.1.0
166170

167-
* Add support to recover authentication for Android.
171+
- Add support to recover authentication for Android.
168172

169173
## 3.0.6
170174

171-
* Remove flaky displayName assertion
175+
- Remove flaky displayName assertion
172176

173177
## 3.0.5
174178

175-
* Added missing http package dependency.
179+
- Added missing http package dependency.
176180

177181
## 3.0.4
178182

179-
* Updated Gradle tooling to match Android Studio 3.1.2.
183+
- Updated Gradle tooling to match Android Studio 3.1.2.
180184

181185
## 3.0.3+1
182186

183-
* Added documentation on where to find the list of available scopes.
187+
- Added documentation on where to find the list of available scopes.
184188

185189
## 3.0.3
186190

187-
* Added support for games sign in on Android.
191+
- Added support for games sign in on Android.
188192

189193
## 3.0.2
190194

191-
* Updated Google Play Services dependency to version 15.0.0.
195+
- Updated Google Play Services dependency to version 15.0.0.
192196

193197
## 3.0.1
194198

195-
* Simplified podspec for Cocoapods 1.5.0, avoiding link issues in app archives.
199+
- Simplified podspec for Cocoapods 1.5.0, avoiding link issues in app archives.
196200

197201
## 3.0.0
198202

199-
* **Breaking change**. Set SDK constraints to match the Flutter beta release.
203+
- **Breaking change**. Set SDK constraints to match the Flutter beta release.
200204

201205
## 2.1.2
202206

203-
* Added a Delegate interface (IDelegate) that can be implemented by clients in
207+
- Added a Delegate interface (IDelegate) that can be implemented by clients in
204208
order to override the functionality (for testing purposes for example).
205209

206210
## 2.1.1
207211

208-
* Fixed Dart 2 type errors.
212+
- Fixed Dart 2 type errors.
209213

210214
## 2.1.0
211215

212-
* Enabled use in Swift projects.
216+
- Enabled use in Swift projects.
213217

214218
## 2.0.1
215219

216-
* Simplified and upgraded Android project template to Android SDK 27.
217-
* Updated package description.
220+
- Simplified and upgraded Android project template to Android SDK 27.
221+
- Updated package description.
218222

219223
## 2.0.0
220224

221-
* **Breaking change**. Upgraded to Gradle 4.1 and Android Studio Gradle plugin
225+
- **Breaking change**. Upgraded to Gradle 4.1 and Android Studio Gradle plugin
222226
3.0.1. Older Flutter projects need to upgrade their Gradle setup as well in
223227
order to use this version of the plugin. Instructions can be found
224228
[here](https://github.com/flutter/flutter/wiki/Updating-Flutter-projects-to-Gradle-4.1-and-Android-Studio-Gradle-plugin-3.0.1).
225-
* Relaxed GMS dependency to [11.4.0,12.0[
229+
- Relaxed GMS dependency to [11.4.0,12.0[
226230

227231
## 1.0.3
228232

229-
* Add FLT prefix to iOS types
233+
- Add FLT prefix to iOS types
230234

231235
## 1.0.2
232236

233-
* Support setting foregroundColor in the avatar.
237+
- Support setting foregroundColor in the avatar.
234238

235239
## 1.0.1
236240

237-
* Change GMS dependency to 11.+
241+
- Change GMS dependency to 11.+
238242

239243
## 1.0.0
240244

241-
* Make GoogleUserCircleAvatar fade profile image over the top of placeholder
242-
* Bump to released version
245+
- Make GoogleUserCircleAvatar fade profile image over the top of placeholder
246+
- Bump to released version
243247

244248
## 0.3.1
245249

246-
* Updated GMS to always use latest patch version for 11.0.x builds
250+
- Updated GMS to always use latest patch version for 11.0.x builds
247251

248252
## 0.3.0
249253

250-
* Add a new `GoogleIdentity` interface, implemented by `GoogleSignInAccount`.
251-
* Move `GoogleUserCircleAvatar` to "widgets" library (exported by
254+
- Add a new `GoogleIdentity` interface, implemented by `GoogleSignInAccount`.
255+
- Move `GoogleUserCircleAvatar` to "widgets" library (exported by
252256
base library for backwards compatibility) and make it take an instance
253257
of `GoogleIdentity`, thus allowing it to be used by other packages that
254258
provide implementations of `GoogleIdentity`.
255259

256260
## 0.2.1
257261

258-
* Plugin can (once again) be used in apps that extend `FlutterActivity`
259-
* `signInSilently` is guaranteed to never throw
260-
* A failed sign-in (caused by a failing `init` step) will no longer block subsequent sign-in attempts
262+
- Plugin can (once again) be used in apps that extend `FlutterActivity`
263+
- `signInSilently` is guaranteed to never throw
264+
- A failed sign-in (caused by a failing `init` step) will no longer block subsequent sign-in attempts
261265

262266
## 0.2.0
263267

264-
* Updated dependencies
265-
* **Breaking Change**: You need to add a maven section with the "https://maven.google.com" endpoint to the repository section of your `android/build.gradle`. For example:
268+
- Updated dependencies
269+
- **Breaking Change**: You need to add a maven section with the "https://maven.google.com" endpoint to the repository section of your `android/build.gradle`. For example:
270+
266271
```gradle
267272
allprojects {
268273
repositories {
@@ -276,35 +281,34 @@ allprojects {
276281

277282
## 0.1.0
278283

279-
* Update to use `GoogleSignIn` CocoaPod
280-
284+
- Update to use `GoogleSignIn` CocoaPod
281285

282286
## 0.0.6
283287

284-
* Fix crash on iOS when signing in caused by nil uiDelegate
288+
- Fix crash on iOS when signing in caused by nil uiDelegate
285289

286290
## 0.0.5
287291

288-
* Require the use of `support-v4` library on Android. This is an API change in
292+
- Require the use of `support-v4` library on Android. This is an API change in
289293
that plugin users will need their activity class to be an instance of
290294
`android.support.v4.app.FragmentActivity`. Flutter framework provides such
291295
an activity out of the box: `io.flutter.app.FlutterFragmentActivity`
292-
* Ignore "Broken pipe" errors affecting iOS simulator
293-
* Update to non-deprecated `application:openURL:options:` on iOS
296+
- Ignore "Broken pipe" errors affecting iOS simulator
297+
- Update to non-deprecated `application:openURL:options:` on iOS
294298

295299
## 0.0.4
296300

297-
* Prevent race conditions when GoogleSignIn methods are called concurrently (#94)
301+
- Prevent race conditions when GoogleSignIn methods are called concurrently (#94)
298302

299303
## 0.0.3
300304

301-
* Fix signOut and disconnect (they were silently ignored)
302-
* Fix test (#10050)
305+
- Fix signOut and disconnect (they were silently ignored)
306+
- Fix test (#10050)
303307

304308
## 0.0.2
305309

306-
* Don't try to sign in again if user is already signed in
310+
- Don't try to sign in again if user is already signed in
307311

308312
## 0.0.1
309313

310-
* Initial Release
314+
- Initial Release

packages/google_sign_in/google_sign_in/ios/Classes/FLTGoogleSignInPlugin.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ - (BOOL)setAccountRequest:(FlutterResult)request {
138138
}
139139

140140
- (BOOL)application:(UIApplication *)app openURL:(NSURL *)url options:(NSDictionary *)options {
141-
NSString *sourceApplication = options[UIApplicationOpenURLOptionsSourceApplicationKey];
142141
return [[GIDSignIn sharedInstance] handleURL:url];
143142
}
144143

0 commit comments

Comments
 (0)