Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 7ac1d4d

Browse files
committed
[google_sign_in] Mark iOS arm64 simulators as unsupported
1 parent a3accd7 commit 7ac1d4d

File tree

5 files changed

+9
-11
lines changed

5 files changed

+9
-11
lines changed

packages/google_sign_in/google_sign_in/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 5.1.0
2+
3+
* Mark iOS arm64 simulators as unsupported.
4+
15
## 5.0.6
26

37
* Remove references to the Android V1 embedding.

packages/google_sign_in/google_sign_in/example/ios/Podfile

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,5 @@ end
3939
post_install do |installer|
4040
installer.pods_project.targets.each do |target|
4141
flutter_additional_ios_build_settings(target)
42-
target.build_configurations.each do |build_configuration|
43-
# GoogleSignIn does not support arm64 simulators.
44-
build_configuration.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64 i386'
45-
end
4642
end
4743
end

packages/google_sign_in/google_sign_in/example/ios/Runner.xcodeproj/project.pbxproj

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@
407407
);
408408
runOnlyForDeploymentPostprocessing = 0;
409409
shellPath = /bin/sh;
410-
shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" build";
410+
shellScript = "/bin/sh \"$FLUTTER_ROOT/packages/flutter_tools/bin/xcode_backend.sh\" build\n";
411411
};
412412
AB1344B0443C71CD721E1BB7 /* [CP] Check Pods Manifest.lock */ = {
413413
isa = PBXShellScriptBuildPhase;
@@ -603,7 +603,6 @@
603603
buildSettings = {
604604
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
605605
ENABLE_BITCODE = NO;
606-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
607606
FRAMEWORK_SEARCH_PATHS = (
608607
"$(inherited)",
609608
"$(PROJECT_DIR)/Flutter",
@@ -625,7 +624,6 @@
625624
buildSettings = {
626625
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
627626
ENABLE_BITCODE = NO;
628-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
629627
FRAMEWORK_SEARCH_PATHS = (
630628
"$(inherited)",
631629
"$(PROJECT_DIR)/Flutter",
@@ -647,7 +645,6 @@
647645
buildSettings = {
648646
BUNDLE_LOADER = "$(TEST_HOST)";
649647
CODE_SIGN_STYLE = Automatic;
650-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
651648
INFOPLIST_FILE = RunnerTests/Info.plist;
652649
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
653650
PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;
@@ -662,7 +659,6 @@
662659
buildSettings = {
663660
BUNDLE_LOADER = "$(TEST_HOST)";
664661
CODE_SIGN_STYLE = Automatic;
665-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "i386 arm64";
666662
INFOPLIST_FILE = RunnerTests/Info.plist;
667663
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
668664
PRODUCT_BUNDLE_IDENTIFIER = dev.flutter.plugins.RunnerTests;

packages/google_sign_in/google_sign_in/ios/google_sign_in.podspec

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,7 @@ Enables Google Sign-In in Flutter apps.
2020
s.static_framework = true
2121

2222
s.platform = :ios, '8.0'
23-
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' }
23+
24+
# GoogleSignIn ~> 5.0 does not support arm64 simulators.
25+
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES', 'EXCLUDED_ARCHS[sdk=iphonesimulator*]' => 'arm64' }
2426
end

packages/google_sign_in/google_sign_in/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for Google Sign-In, a secure authentication system
33
for signing in with a Google account on Android and iOS.
44
repository: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in
55
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
6-
version: 5.0.6
6+
version: 5.1.0
77

88
environment:
99
sdk: ">=2.12.0 <3.0.0"

0 commit comments

Comments
 (0)