Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 9e67070

Browse files
authored
[Conductor] Update post submit location (#106120)
* readability refactor * update post-submits Update post submit testing status location from LUCI to cocoon. Conductor users will still have to use navigation to pick the correct repository and release candidate to monitor.
1 parent 995b332 commit 9e67070

File tree

2 files changed

+39
-12
lines changed

2 files changed

+39
-12
lines changed

dev/conductor/core/lib/src/globals.dart

Lines changed: 37 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,36 @@ const String kForceFlag = 'force';
1414

1515
const List<String> kBaseReleaseChannels = <String>['stable', 'beta'];
1616

17-
const List<String> kReleaseChannels = <String>[...kBaseReleaseChannels, FrameworkRepository.defaultBranch];
17+
const List<String> kReleaseChannels = <String>[
18+
...kBaseReleaseChannels,
19+
FrameworkRepository.defaultBranch
20+
];
1821

19-
const String kReleaseDocumentationUrl = 'https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process';
22+
const String kReleaseDocumentationUrl =
23+
'https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process';
2024

21-
const String kLuciPackagingConsoleLink = 'https://ci.chromium.org/p/flutter/g/packaging/console';
25+
const String kLuciPackagingConsoleLink =
26+
'https://ci.chromium.org/p/flutter/g/packaging/console';
2227

23-
const String kWebsiteReleasesUrl = 'https://docs.flutter.dev/development/tools/sdk/releases';
28+
const String kWebsiteReleasesUrl =
29+
'https://docs.flutter.dev/development/tools/sdk/releases';
30+
31+
const String discordReleaseChannel =
32+
'https://discord.com/channels/608014603317936148/783492179922124850';
33+
34+
const String flutterReleaseHotline =
35+
'https://mail.google.com/chat/u/0/#chat/space/AAAA6RKcK2k';
36+
37+
const String hotfixToStableWiki =
38+
'https://github.com/flutter/flutter/wiki/Hotfixes-to-the-Stable-Channel';
39+
40+
const String flutterAnnounceGroup =
41+
'https://groups.google.com/g/flutter-announce';
42+
43+
const String hotfixDocumentationBestPractices =
44+
'https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices';
45+
46+
const String cocoonDashboard = 'https://flutter-dashboard.appspot.com/#/build';
2447

2548
const String discordReleaseChannel =
2649
'https://discord.com/channels/608014603317936148/783492179922124850';
@@ -96,7 +119,8 @@ String? getValueFromEnvOrArgs(
96119
if (allowNull) {
97120
return null;
98121
}
99-
throw ConductorException('Expected either the CLI arg --$name or the environment variable $envName '
122+
throw ConductorException(
123+
'Expected either the CLI arg --$name or the environment variable $envName '
100124
'to be provided!');
101125
}
102126

@@ -135,7 +159,8 @@ List<String> getValuesFromEnvOrArgs(
135159
return argValues;
136160
}
137161

138-
throw ConductorException('Expected either the CLI arg --$name or the environment variable $envName '
162+
throw ConductorException(
163+
'Expected either the CLI arg --$name or the environment variable $envName '
139164
'to be provided!');
140165
}
141166

@@ -171,7 +196,8 @@ String getNewPrLink({
171196
repoLabel = 'Engine';
172197
break;
173198
default:
174-
throw ConductorException('Expected repoName to be one of flutter or engine but got $repoName.');
199+
throw ConductorException(
200+
'Expected repoName to be one of flutter or engine but got $repoName.');
175201
}
176202
assert(candidateBranch.isNotEmpty);
177203
assert(workingBranch.isNotEmpty);
@@ -188,12 +214,14 @@ String getNewPrLink({
188214
if (state.engine.dartRevision.isNotEmpty) {
189215
// shorten hashes to make final link manageable
190216
// prefix with github org/repo so GitHub will auto-generate a hyperlink
191-
body.writeln('- Roll dart revision: dart-lang/sdk@${state.engine.dartRevision.substring(0, 9)}');
217+
body.writeln(
218+
'- Roll dart revision: dart-lang/sdk@${state.engine.dartRevision.substring(0, 9)}');
192219
}
193220
for (final pb.Cherrypick cp in state.engine.cherrypicks) {
194221
// Only list commits that map to a commit that exists upstream.
195222
if (cp.trunkRevision.isNotEmpty) {
196-
body.writeln('- commit: flutter/engine@${cp.trunkRevision.substring(0, 9)}');
223+
body.writeln(
224+
'- commit: flutter/engine@${cp.trunkRevision.substring(0, 9)}');
197225
}
198226
}
199227
} else {

dev/conductor/core/lib/src/state.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ String presentState(pb.ConductorState state) {
7777
buffer.writeln('\tCurrent git HEAD: ${state.engine.currentGitHead}');
7878
buffer.writeln('\tPath to checkout: ${state.engine.checkoutPath}');
7979
buffer.writeln(
80-
'\tPost-submit LUCI dashboard: ${luciConsoleLink(state.releaseChannel, 'engine')}');
80+
'\tPost-submit cocoon dashboard: ${globals.cocoonDashboard}');
8181
if (state.engine.cherrypicks.isNotEmpty) {
8282
buffer.writeln('${state.engine.cherrypicks.length} Engine Cherrypicks:');
8383
for (final pb.Cherrypick cherrypick in state.engine.cherrypicks) {
@@ -95,8 +95,7 @@ String presentState(pb.ConductorState state) {
9595
buffer.writeln('\tStarting git HEAD: ${state.framework.startingGitHead}');
9696
buffer.writeln('\tCurrent git HEAD: ${state.framework.currentGitHead}');
9797
buffer.writeln('\tPath to checkout: ${state.framework.checkoutPath}');
98-
buffer.writeln(
99-
'\tPost-submit LUCI dashboard: ${luciConsoleLink(state.releaseChannel, 'flutter')}');
98+
buffer.writeln('\tPost-submit cocoon dashboard: ${globals.cocoonDashboard}');
10099
if (state.framework.cherrypicks.isNotEmpty) {
101100
buffer.writeln(
102101
'${state.framework.cherrypicks.length} Framework Cherrypicks:');

0 commit comments

Comments
 (0)