Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit ef032a4

Browse files
committed
bump patch version
fix unused variable warnings nit
1 parent e1e5835 commit ef032a4

File tree

4 files changed

+15
-10
lines changed

4 files changed

+15
-10
lines changed

packages/quick_actions/quick_actions_ios/CHANGELOG.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## 1.0.0+1
1+
## 1.0.1
22

33
* Removes custom modulemap file with "Test" submodule and private headers for Swift migration.
44
* Migrates `FLTQuickActionsPlugin` class to Swift.

packages/quick_actions/quick_actions_ios/example/ios/RunnerTests/FLTQuickActionsPluginTests.m

+12-7
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,10 @@ - (void)testApplicationDidBecomeActive_launchWithoutShortcut {
153153
[[QuickActionsPlugin alloc] initWithChannel:mockChannel
154154
shortcutStateManager:mockShortcutStateManager];
155155

156-
[plugin application:[UIApplication sharedApplication] didFinishLaunchingWithOptions:@{}];
156+
BOOL launchResult = [plugin application:[UIApplication sharedApplication]
157+
didFinishLaunchingWithOptions:@{}];
158+
XCTAssertTrue(launchResult,
159+
@"didFinishLaunchingWithOptions must return true if not launched from shortcut.");
157160
[plugin applicationDidBecomeActive:[UIApplication sharedApplication]];
158161
OCMVerify(never(), [mockChannel invokeMethod:OCMOCK_ANY arguments:OCMOCK_ANY]);
159162
}
@@ -172,9 +175,10 @@ - (void)testApplicationDidBecomeActive_launchWithShortcut {
172175
icon:[UIApplicationShortcutIcon
173176
iconWithTemplateImageName:@"search_the_thing.png"]
174177
userInfo:nil];
175-
[plugin application:[UIApplication sharedApplication]
176-
didFinishLaunchingWithOptions:@{UIApplicationLaunchOptionsShortcutItemKey : item}];
177-
178+
BOOL launchResult = [plugin application:[UIApplication sharedApplication]
179+
didFinishLaunchingWithOptions:@{UIApplicationLaunchOptionsShortcutItemKey : item}];
180+
XCTAssertFalse(launchResult,
181+
@"didFinishLaunchingWithOptions must return false if launched from shortcut.");
178182
[plugin applicationDidBecomeActive:[UIApplication sharedApplication]];
179183
OCMVerify([mockChannel invokeMethod:@"launch" arguments:item.type]);
180184
}
@@ -193,9 +197,10 @@ - (void)testApplicationDidBecomeActive_launchWithShortcut_becomeActiveTwice {
193197
icon:[UIApplicationShortcutIcon
194198
iconWithTemplateImageName:@"search_the_thing.png"]
195199
userInfo:nil];
196-
[plugin application:[UIApplication sharedApplication]
197-
didFinishLaunchingWithOptions:@{UIApplicationLaunchOptionsShortcutItemKey : item}];
198-
200+
BOOL launchResult = [plugin application:[UIApplication sharedApplication]
201+
didFinishLaunchingWithOptions:@{UIApplicationLaunchOptionsShortcutItemKey : item}];
202+
XCTAssertFalse(launchResult,
203+
@"didFinishLaunchingWithOptions must return false if launched from shortcut.");
199204
[plugin applicationDidBecomeActive:[UIApplication sharedApplication]];
200205
[plugin applicationDidBecomeActive:[UIApplication sharedApplication]];
201206
// shortcut should only be handled once per launch.

packages/quick_actions/quick_actions_ios/ios/Classes/QuickActionsPlugin.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public final class QuickActionsPlugin: NSObject, FlutterPlugin {
3333
public func handle(_ call: FlutterMethodCall, result: @escaping FlutterResult) {
3434
switch call.method {
3535
case "setShortcutItems":
36-
// `arguments` must be a list of dictionaries
36+
// `arguments` must be an array of dictionaries
3737
let items = call.arguments as! [[String: Any]]
3838
shortcutStateManager.setShortcutItems(items)
3939
result(nil)

packages/quick_actions/quick_actions_ios/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: quick_actions_ios
22
description: An implementation for the iOS platform of the Flutter `quick_actions` plugin.
33
repository: https://github.com/flutter/plugins/tree/main/packages/quick_actions/quick_actions_ios
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+in_app_purchase%22
5-
version: 1.0.0+1
5+
version: 1.0.1
66

77
environment:
88
sdk: ">=2.15.0 <3.0.0"

0 commit comments

Comments
 (0)