Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit fecd22e

Browse files
[google_maps_flutter] Clean Java test, consolidate Marker example. (#4400)
* Do not mock internal class * Merge "Marker" examples into a single page.
1 parent 3bffbf8 commit fecd22e

File tree

4 files changed

+131
-283
lines changed

4 files changed

+131
-283
lines changed

packages/google_maps_flutter/google_maps_flutter/android/src/test/java/io/flutter/plugins/googlemaps/MarkersControllerTest.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import static org.mockito.Mockito.spy;
1010
import static org.mockito.Mockito.when;
1111

12-
import com.google.android.gms.internal.maps.zzt;
1312
import com.google.android.gms.maps.GoogleMap;
1413
import com.google.android.gms.maps.model.LatLng;
1514
import com.google.android.gms.maps.model.Marker;
@@ -35,8 +34,7 @@ public void controller_OnMarkerDragStart() {
3534
final GoogleMap googleMap = mock(GoogleMap.class);
3635
controller.setGoogleMap(googleMap);
3736

38-
final zzt z = mock(zzt.class);
39-
final Marker marker = new Marker(z);
37+
final Marker marker = mock(Marker.class);
4038

4139
final String googleMarkerId = "abc123";
4240

@@ -69,8 +67,7 @@ public void controller_OnMarkerDragEnd() {
6967
final GoogleMap googleMap = mock(GoogleMap.class);
7068
controller.setGoogleMap(googleMap);
7169

72-
final zzt z = mock(zzt.class);
73-
final Marker marker = new Marker(z);
70+
final Marker marker = mock(Marker.class);
7471

7572
final String googleMarkerId = "abc123";
7673

@@ -103,8 +100,7 @@ public void controller_OnMarkerDrag() {
103100
final GoogleMap googleMap = mock(GoogleMap.class);
104101
controller.setGoogleMap(googleMap);
105102

106-
final zzt z = mock(zzt.class);
107-
final Marker marker = new Marker(z);
103+
final Marker marker = mock(Marker.class);
108104

109105
final String googleMarkerId = "abc123";
110106

packages/google_maps_flutter/google_maps_flutter/example/lib/drag_marker.dart

Lines changed: 0 additions & 156 deletions
This file was deleted.

packages/google_maps_flutter/google_maps_flutter/example/lib/main.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
// ignore_for_file: public_member_api_docs
66

77
import 'package:flutter/material.dart';
8-
import 'package:google_maps_flutter_example/drag_marker.dart';
98
import 'package:google_maps_flutter_example/lite_mode.dart';
109
import 'animate_camera.dart';
1110
import 'map_click.dart';
@@ -35,7 +34,6 @@ final List<GoogleMapExampleAppPage> _allPages = <GoogleMapExampleAppPage>[
3534
PlacePolylinePage(),
3635
PlacePolygonPage(),
3736
PlaceCirclePage(),
38-
DragMarkerPage(),
3937
PaddingPage(),
4038
SnapshotPage(),
4139
LiteModePage(),

0 commit comments

Comments
 (0)