diff --git a/packages/google_maps_flutter/CHANGELOG.md b/packages/google_maps_flutter/CHANGELOG.md index 2c83c6449da9..6ea04694815a 100644 --- a/packages/google_maps_flutter/CHANGELOG.md +++ b/packages/google_maps_flutter/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.5.21+11 + +* Define clang module for iOS, fix analyzer warnings. + ## 0.5.21+10 * Cast error.code to unsigned long to avoid using NSInteger as %ld format warnings. diff --git a/packages/google_maps_flutter/example/ios/Runner/AppDelegate.m b/packages/google_maps_flutter/example/ios/Runner/AppDelegate.m index 893deae584b0..6896c5c190b1 100644 --- a/packages/google_maps_flutter/example/ios/Runner/AppDelegate.m +++ b/packages/google_maps_flutter/example/ios/Runner/AppDelegate.m @@ -1,6 +1,7 @@ -#include "AppDelegate.h" -#include "GeneratedPluginRegistrant.h" -#import "GoogleMaps/GoogleMaps.h" +#import "AppDelegate.h" +#import "GeneratedPluginRegistrant.h" + +@import GoogleMaps; @implementation AppDelegate diff --git a/packages/google_maps_flutter/ios/Classes/GoogleMapCircleController.m b/packages/google_maps_flutter/ios/Classes/GoogleMapCircleController.m index 92e951200437..6688d4d57695 100644 --- a/packages/google_maps_flutter/ios/Classes/GoogleMapCircleController.m +++ b/packages/google_maps_flutter/ios/Classes/GoogleMapCircleController.m @@ -73,17 +73,17 @@ static CLLocationDistance ToDistance(NSNumber* data) { static void InterpretCircleOptions(NSDictionary* data, id sink, NSObject* registrar) { NSNumber* consumeTapEvents = data[@"consumeTapEvents"]; - if (consumeTapEvents) { + if (consumeTapEvents != nil) { [sink setConsumeTapEvents:ToBool(consumeTapEvents)]; } NSNumber* visible = data[@"visible"]; - if (visible) { + if (visible != nil) { [sink setVisible:ToBool(visible)]; } NSNumber* zIndex = data[@"zIndex"]; - if (zIndex) { + if (zIndex != nil) { [sink setZIndex:ToInt(zIndex)]; } @@ -93,22 +93,22 @@ static void InterpretCircleOptions(NSDictionary* data, id - (instancetype)initWithFrame:(CGRect)frame viewIdentifier:(int64_t)viewId - arguments:(id _Nullable)args + arguments:(nullable id)args registrar:(NSObject *)registrar; - (void)showAtX:(CGFloat)x Y:(CGFloat)y; - (void)hide; - (void)animateWithCameraUpdate:(GMSCameraUpdate *)cameraUpdate; - (void)moveWithCameraUpdate:(GMSCameraUpdate *)cameraUpdate; -- (GMSCameraPosition *)cameraPosition; +- (nullable GMSCameraPosition *)cameraPosition; @end // Allows the engine to create new Google Map instances. @@ -49,4 +49,4 @@ NS_ASSUME_NONNULL_BEGIN - (instancetype)initWithRegistrar:(NSObject *)registrar; @end -NS_ASSUME_NONNULL_END \ No newline at end of file +NS_ASSUME_NONNULL_END diff --git a/packages/google_maps_flutter/ios/Classes/GoogleMapController.m b/packages/google_maps_flutter/ios/Classes/GoogleMapController.m index 70a278af45de..ce85887d5d97 100644 --- a/packages/google_maps_flutter/ios/Classes/GoogleMapController.m +++ b/packages/google_maps_flutter/ios/Classes/GoogleMapController.m @@ -65,7 +65,7 @@ - (instancetype)initWithFrame:(CGRect)frame viewIdentifier:(int64_t)viewId arguments:(id _Nullable)args registrar:(NSObject*)registrar { - if ([super init]) { + if (self = [super init]) { _viewId = viewId; GMSCameraPosition* camera = ToOptionalCameraPosition(args[@"initialCameraPosition"]); @@ -543,7 +543,7 @@ static void InterpretMapOptions(NSDictionary* data, id [sink setCameraTargetBounds:ToOptionalBounds(cameraTargetBounds)]; } NSNumber* compassEnabled = data[@"compassEnabled"]; - if (compassEnabled) { + if (compassEnabled != nil) { [sink setCompassEnabled:ToBool(compassEnabled)]; } id indoorEnabled = data[@"indoorEnabled"]; @@ -574,31 +574,31 @@ static void InterpretMapOptions(NSDictionary* data, id } NSNumber* rotateGesturesEnabled = data[@"rotateGesturesEnabled"]; - if (rotateGesturesEnabled) { + if (rotateGesturesEnabled != nil) { [sink setRotateGesturesEnabled:ToBool(rotateGesturesEnabled)]; } NSNumber* scrollGesturesEnabled = data[@"scrollGesturesEnabled"]; - if (scrollGesturesEnabled) { + if (scrollGesturesEnabled != nil) { [sink setScrollGesturesEnabled:ToBool(scrollGesturesEnabled)]; } NSNumber* tiltGesturesEnabled = data[@"tiltGesturesEnabled"]; - if (tiltGesturesEnabled) { + if (tiltGesturesEnabled != nil) { [sink setTiltGesturesEnabled:ToBool(tiltGesturesEnabled)]; } NSNumber* trackCameraPosition = data[@"trackCameraPosition"]; - if (trackCameraPosition) { + if (trackCameraPosition != nil) { [sink setTrackCameraPosition:ToBool(trackCameraPosition)]; } NSNumber* zoomGesturesEnabled = data[@"zoomGesturesEnabled"]; - if (zoomGesturesEnabled) { + if (zoomGesturesEnabled != nil) { [sink setZoomGesturesEnabled:ToBool(zoomGesturesEnabled)]; } NSNumber* myLocationEnabled = data[@"myLocationEnabled"]; - if (myLocationEnabled) { + if (myLocationEnabled != nil) { [sink setMyLocationEnabled:ToBool(myLocationEnabled)]; } NSNumber* myLocationButtonEnabled = data[@"myLocationButtonEnabled"]; - if (myLocationButtonEnabled) { + if (myLocationButtonEnabled != nil) { [sink setMyLocationButtonEnabled:ToBool(myLocationButtonEnabled)]; } } diff --git a/packages/google_maps_flutter/ios/Classes/GoogleMapMarkerController.m b/packages/google_maps_flutter/ios/Classes/GoogleMapMarkerController.m index 2f0d4a989b9d..76a420f993db 100644 --- a/packages/google_maps_flutter/ios/Classes/GoogleMapMarkerController.m +++ b/packages/google_maps_flutter/ios/Classes/GoogleMapMarkerController.m @@ -95,7 +95,7 @@ static CLLocationCoordinate2D ToLocation(NSArray* data) { static void InterpretMarkerOptions(NSDictionary* data, id sink, NSObject* registrar) { NSNumber* alpha = data[@"alpha"]; - if (alpha) { + if (alpha != nil) { [sink setAlpha:ToFloat(alpha)]; } NSArray* anchor = data[@"anchor"]; @@ -103,7 +103,7 @@ static void InterpretMarkerOptions(NSDictionary* data, id sink, NSObject* registrar) { NSNumber* consumeTapEvents = data[@"consumeTapEvents"]; - if (consumeTapEvents) { + if (consumeTapEvents != nil) { [sink setConsumeTapEvents:ToBool(consumeTapEvents)]; } NSNumber* visible = data[@"visible"]; - if (visible) { + if (visible != nil) { [sink setVisible:ToBool(visible)]; } NSNumber* zIndex = data[@"zIndex"]; - if (zIndex) { + if (zIndex != nil) { [sink setZIndex:ToInt(zIndex)]; } @@ -90,17 +90,17 @@ static void InterpretPolygonOptions(NSDictionary* data, id sink, NSObject* registrar) { NSNumber* consumeTapEvents = data[@"consumeTapEvents"]; - if (consumeTapEvents) { + if (consumeTapEvents != nil) { [sink setConsumeTapEvents:ToBool(consumeTapEvents)]; } NSNumber* visible = data[@"visible"]; - if (visible) { + if (visible != nil) { [sink setVisible:ToBool(visible)]; } NSNumber* zIndex = data[@"zIndex"]; - if (zIndex) { + if (zIndex != nil) { [sink setZIndex:ToInt(zIndex)]; } @@ -87,12 +87,12 @@ static void InterpretPolylineOptions(NSDictionary* data, id 'YES', 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64' } end diff --git a/packages/google_maps_flutter/pubspec.yaml b/packages/google_maps_flutter/pubspec.yaml index 3fed14e299c0..fc683bb1bba6 100644 --- a/packages/google_maps_flutter/pubspec.yaml +++ b/packages/google_maps_flutter/pubspec.yaml @@ -2,7 +2,7 @@ name: google_maps_flutter description: A Flutter plugin for integrating Google Maps in iOS and Android applications. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter -version: 0.5.21+10 +version: 0.5.21+11 dependencies: flutter: diff --git a/script/lint_darwin_plugins.sh b/script/lint_darwin_plugins.sh index 94041c728191..84c5f2a8dcfa 100755 --- a/script/lint_darwin_plugins.sh +++ b/script/lint_darwin_plugins.sh @@ -70,16 +70,8 @@ function lint_packages() { return fi - # TODO: These packages have linter errors. Remove plugins from this list as linter issues are fixed. - local skipped_packages=( - 'google_maps_flutter' - ) - local failure_count=0 - for package_name in "$@"; do - if [[ "${skipped_packages[*]}" =~ "${package_name}" ]]; then - continue - fi + for package_name in "$@"; do lint_package "${package_name}" failure_count+="$?" done