Skip to content

Commit 656d8d3

Browse files
authored
[connectivity_plus] remove members that were moved to network_info_plus (#109)
* [connectivity_plus] remove deprecated members * [connectivity_plus] bump versions & update changelogs
1 parent 3c4e898 commit 656d8d3

29 files changed

+37
-825
lines changed

packages/connectivity_plus/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.8.0
2+
3+
- Removed members that were moved to network_info_plus
4+
15
## 0.7.2
26

37
- Deprecated the following members (use network_info_plus instead):
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
22
package="dev.fluttercommunity.plus.connectivity">
33
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
4-
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
54
</manifest>

packages/connectivity_plus/android/src/main/java/dev/fluttercommunity/plus/connectivity/Connectivity.java

+1-43
Original file line numberDiff line numberDiff line change
@@ -8,18 +8,14 @@
88
import android.net.Network;
99
import android.net.NetworkCapabilities;
1010
import android.net.NetworkInfo;
11-
import android.net.wifi.WifiInfo;
12-
import android.net.wifi.WifiManager;
1311
import android.os.Build;
1412

1513
/** Reports connectivity related information such as connectivity type and wifi information. */
1614
class Connectivity {
1715
private ConnectivityManager connectivityManager;
18-
private WifiManager wifiManager;
1916

20-
Connectivity(ConnectivityManager connectivityManager, WifiManager wifiManager) {
17+
Connectivity(ConnectivityManager connectivityManager) {
2118
this.connectivityManager = connectivityManager;
22-
this.wifiManager = wifiManager;
2319
}
2420

2521
String getNetworkType() {
@@ -41,44 +37,6 @@ String getNetworkType() {
4137
return getNetworkTypeLegacy();
4238
}
4339

44-
String getWifiName() {
45-
WifiInfo wifiInfo = getWifiInfo();
46-
String ssid = null;
47-
if (wifiInfo != null) ssid = wifiInfo.getSSID();
48-
if (ssid != null) ssid = ssid.replaceAll("\"", ""); // Android returns "SSID"
49-
return ssid;
50-
}
51-
52-
String getWifiBSSID() {
53-
WifiInfo wifiInfo = getWifiInfo();
54-
String bssid = null;
55-
if (wifiInfo != null) {
56-
bssid = wifiInfo.getBSSID();
57-
}
58-
return bssid;
59-
}
60-
61-
String getWifiIPAddress() {
62-
WifiInfo wifiInfo = null;
63-
if (wifiManager != null) wifiInfo = wifiManager.getConnectionInfo();
64-
65-
String ip = null;
66-
int i_ip = 0;
67-
if (wifiInfo != null) i_ip = wifiInfo.getIpAddress();
68-
69-
if (i_ip != 0)
70-
ip =
71-
String.format(
72-
"%d.%d.%d.%d",
73-
(i_ip & 0xff), (i_ip >> 8 & 0xff), (i_ip >> 16 & 0xff), (i_ip >> 24 & 0xff));
74-
75-
return ip;
76-
}
77-
78-
private WifiInfo getWifiInfo() {
79-
return wifiManager == null ? null : wifiManager.getConnectionInfo();
80-
}
81-
8240
@SuppressWarnings("deprecation")
8341
private String getNetworkTypeLegacy() {
8442
// handle type for Android versions less than Android 9

packages/connectivity_plus/android/src/main/java/dev/fluttercommunity/plus/connectivity/ConnectivityMethodChannelHandler.java

-9
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,6 @@ public void onMethodCall(MethodCall call, MethodChannel.Result result) {
3131
case "check":
3232
result.success(connectivity.getNetworkType());
3333
break;
34-
case "wifiName":
35-
result.success(connectivity.getWifiName());
36-
break;
37-
case "wifiBSSID":
38-
result.success(connectivity.getWifiBSSID());
39-
break;
40-
case "wifiIPAddress":
41-
result.success(connectivity.getWifiIPAddress());
42-
break;
4334
default:
4435
result.notImplemented();
4536
break;

packages/connectivity_plus/android/src/main/java/dev/fluttercommunity/plus/connectivity/ConnectivityPlugin.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
import android.content.Context;
88
import android.net.ConnectivityManager;
9-
import android.net.wifi.WifiManager;
109
import io.flutter.embedding.engine.plugins.FlutterPlugin;
1110
import io.flutter.plugin.common.BinaryMessenger;
1211
import io.flutter.plugin.common.EventChannel;
@@ -41,9 +40,8 @@ private void setupChannels(BinaryMessenger messenger, Context context) {
4140
eventChannel = new EventChannel(messenger, "dev.fluttercommunity.plus/connectivity_status");
4241
ConnectivityManager connectivityManager =
4342
(ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);
44-
WifiManager wifiManager = (WifiManager) context.getSystemService(Context.WIFI_SERVICE);
4543

46-
Connectivity connectivity = new Connectivity(connectivityManager, wifiManager);
44+
Connectivity connectivity = new Connectivity(connectivityManager);
4745

4846
ConnectivityMethodChannelHandler methodChannelHandler =
4947
new ConnectivityMethodChannelHandler(connectivity);

packages/connectivity_plus/example/lib/main.dart

+1-70
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ import 'package:flutter/foundation.dart';
1212
import 'package:flutter/material.dart';
1313
import 'package:flutter/services.dart';
1414

15-
// ignore_for_file: deprecated_member_use
16-
1715
// Sets a platform override for desktop to avoid exceptions. See
1816
// https://flutter.dev/desktop#target-platform-override for more info.
1917
void _enablePlatformOverrideForDesktop() {
@@ -100,73 +98,6 @@ class _MyHomePageState extends State<MyHomePage> {
10098
}
10199

102100
Future<void> _updateConnectionStatus(ConnectivityResult result) async {
103-
switch (result) {
104-
case ConnectivityResult.wifi:
105-
String wifiName, wifiBSSID, wifiIP;
106-
107-
try {
108-
if (!kIsWeb && Platform.isIOS) {
109-
var status = await _connectivity.getLocationServiceAuthorization();
110-
if (status == LocationAuthorizationStatus.notDetermined) {
111-
status =
112-
await _connectivity.requestLocationServiceAuthorization();
113-
}
114-
if (status == LocationAuthorizationStatus.authorizedAlways ||
115-
status == LocationAuthorizationStatus.authorizedWhenInUse) {
116-
wifiName = await _connectivity.getWifiName();
117-
} else {
118-
wifiName = await _connectivity.getWifiName();
119-
}
120-
} else {
121-
wifiName = await _connectivity.getWifiName();
122-
}
123-
} on PlatformException catch (e) {
124-
print(e.toString());
125-
wifiName = 'Failed to get Wifi Name';
126-
}
127-
128-
try {
129-
if (!kIsWeb && Platform.isIOS) {
130-
var status = await _connectivity.getLocationServiceAuthorization();
131-
if (status == LocationAuthorizationStatus.notDetermined) {
132-
status =
133-
await _connectivity.requestLocationServiceAuthorization();
134-
}
135-
if (status == LocationAuthorizationStatus.authorizedAlways ||
136-
status == LocationAuthorizationStatus.authorizedWhenInUse) {
137-
wifiBSSID = await _connectivity.getWifiBSSID();
138-
} else {
139-
wifiBSSID = await _connectivity.getWifiBSSID();
140-
}
141-
} else {
142-
wifiBSSID = await _connectivity.getWifiBSSID();
143-
}
144-
} on PlatformException catch (e) {
145-
print(e.toString());
146-
wifiBSSID = 'Failed to get Wifi BSSID';
147-
}
148-
149-
try {
150-
wifiIP = await _connectivity.getWifiIP();
151-
} on PlatformException catch (e) {
152-
print(e.toString());
153-
wifiIP = 'Failed to get Wifi IP';
154-
}
155-
156-
setState(() {
157-
_connectionStatus = '$result\n'
158-
'Wifi Name: $wifiName\n'
159-
'Wifi BSSID: $wifiBSSID\n'
160-
'Wifi IP: $wifiIP\n';
161-
});
162-
break;
163-
case ConnectivityResult.mobile:
164-
case ConnectivityResult.none:
165-
setState(() => _connectionStatus = result.toString());
166-
break;
167-
default:
168-
setState(() => _connectionStatus = 'Failed to get connectivity.');
169-
break;
170-
}
101+
setState(() => _connectionStatus = result.toString());
171102
}
172103
}

packages/connectivity_plus/example/test_driver/connectivity_plus_e2e.dart

-19
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,10 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
import 'dart:io';
65
import 'package:integration_test/integration_test.dart';
76
import 'package:flutter_test/flutter_test.dart';
87
import 'package:connectivity_plus/connectivity_plus.dart';
98

10-
// ignore_for_file: deprecated_member_use
11-
129
void main() {
1310
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
1411

@@ -22,22 +19,6 @@ void main() {
2219
testWidgets('test connectivity result', (WidgetTester tester) async {
2320
final result = await _connectivity.checkConnectivity();
2421
expect(result, isNotNull);
25-
switch (result) {
26-
case ConnectivityResult.wifi:
27-
expect(_connectivity.getWifiName(), completes);
28-
expect(_connectivity.getWifiBSSID(), completes);
29-
expect((await _connectivity.getWifiIP()), isNotNull);
30-
break;
31-
default:
32-
break;
33-
}
34-
});
35-
36-
testWidgets('test location methods, iOS only', (WidgetTester tester) async {
37-
if (Platform.isIOS) {
38-
expect((await _connectivity.getLocationServiceAuthorization()),
39-
LocationAuthorizationStatus.notDetermined);
40-
}
4122
});
4223
});
4324
}

packages/connectivity_plus/ios/Classes/FLTConnectivityLocationPlusHandler.h

-22
This file was deleted.

packages/connectivity_plus/ios/Classes/FLTConnectivityLocationPlusHandler.m

-58
This file was deleted.

0 commit comments

Comments
 (0)