Skip to content

Share.shareFiles Windows. #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabio21 opened this issue Jun 29, 2021 · 8 comments · Fixed by #1158
Closed

Share.shareFiles Windows. #333

fabio21 opened this issue Jun 29, 2021 · 8 comments · Fixed by #1158
Labels
bug Something isn't working Hacktoberfest Issues taking part in Hacktoberfest share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin Stale

Comments

@fabio21
Copy link

fabio21 commented Jun 29, 2021

shareFiles() has not been implemented on Windows.

When the exception was thrown, this was the stack:
#0 ShareWindows.shareFiles (package:share_plus_windows/share_plus_windows.dart:48:5)
#1 Share.shareFiles (package:share_plus/share_plus.dart:93:22)

@fabio21 fabio21 added the bug Something isn't working label Jun 29, 2021
@mhadaily mhadaily added the share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin label Jul 6, 2021
@mhadaily
Copy link
Member

mhadaily commented Jul 6, 2021

@jpnurmi do you know anything about this?

@jpnurmi
Copy link
Member

jpnurmi commented Jul 6, 2021

@fabio21, do you happen to be aware of any API to share files on Windows?

@Coronon
Copy link
Contributor

Coronon commented Jul 21, 2021

I think there is no such thing as 'native sharing' under windows. All I could think of is this feature:
image

When you click 'Share' this will allow you to share any file with around 3-4 apps: FeedbackHub, Snip & Sketch, Mail and (at least for me) OneNote. I don't think anyone actually uses this. I literally just discovered this 'feature' when looking for some native sharing ^^

@mhadaily mhadaily added the Hacktoberfest Issues taking part in Hacktoberfest label Sep 28, 2021
@alexmercerind
Copy link
Contributor

I may implement this.

@Coronon
Copy link
Contributor

Coronon commented Apr 1, 2022

I may implement this.

I think there is a general discussion at the moment if it even makes sense to support sharing on non-mobile platforms as pretty much no one uses those native ‘features’ (at least as far as I can tell).

But I don’t want to stop you - go ahead :)

@alexmercerind
Copy link
Contributor

alexmercerind commented Apr 1, 2022

I think there is a general discussion at the moment if it even makes sense to support sharing on non-mobile platforms as pretty much no one uses those native ‘features’ (at least as far as I can tell).

Recently Windows 11 has given developers the ability to list their "non-Windows-Store" apps into this share menu aswell.
Reference: Windows Developers | Extending the Context Menu and Share Dialog in Windows 11

Maybe we can see better apps being mentioned in this dialog soon (how about Flutter ones 😄)? We have a UWP WhatsApp in the store too, which can be good share-target. But still, it's kind of redundant.

@Coronon
Copy link
Contributor

Coronon commented Apr 1, 2022

I didn’t know about that (maybe because I despise the new Windows look and feel? ^^).

If you can get it running that would sure be a nice addition 👍🏻 Maybe even have a look if you can implement the WithResult variant (you can ask me if you have any questions regarding that) :)

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Hacktoberfest Issues taking part in Hacktoberfest share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants