Skip to content

Commit 2eb472e

Browse files
authored
Rollup merge of rust-lang#124594 - jieyouxu:rmake-cc, r=fmease
run-make-support: preserve tooks.mk behavior for EXTRACXXFLAGS In rust-lang#123149 when trying to add a command wrapper for `cc`, I didn't preserve the behavior of tools.mk completely: tools.mk had ```makefile # Extra flags needed to compile a working executable with the standard library ifdef IS_WINDOWS ifdef IS_MSVC #EXTRACFLAGS := ws2_32.lib userenv.lib advapi32.lib bcrypt.lib ntdll.lib synchronization.lib else #EXTRACFLAGS := -lws2_32 -luserenv -lbcrypt -lntdll -lsynchronization EXTRACXXFLAGS := -lstdc++ #EXTRARSCXXFLAGS := -l static:-bundle=stdc++ endif else ifeq ($(UNAME),Darwin) #EXTRACFLAGS := -lresolv EXTRACXXFLAGS := -lc++ #EXTRARSCXXFLAGS := -lc++ else ifeq ($(UNAME),FreeBSD) #EXTRACFLAGS := -lm -lpthread -lgcc_s else ifeq ($(UNAME),SunOS) #EXTRACFLAGS := -lm -lpthread -lposix4 -lsocket -lresolv else ifeq ($(UNAME),OpenBSD) #EXTRACFLAGS := -lm -lpthread -lc++abi #RUSTC := $(RUSTC) -C linker="$(word 1,$(CC:ccache=))" else #EXTRACFLAGS := -lm -lrt -ldl -lpthread EXTRACXXFLAGS := -lstdc++ #EXTRARSCXXFLAGS := -lstdc++ endif endif endif endif endif ``` Note that for {`FreeBSD`, `SunOs`, `OpenBSD`} the `-lstdc++` flag is *not* passed, so `EXTRACXXFLAGS` for those platforms should be an empty `vec![]`. r? ghost (testing this with PR CI)
2 parents dc754ca + 42ecde4 commit 2eb472e

File tree

1 file changed

+3
-2
lines changed
  • src/tools/run-make-support/src

1 file changed

+3
-2
lines changed

Diff for: src/tools/run-make-support/src/cc.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,9 @@ pub fn extra_cxx_flags() -> Vec<&'static str> {
161161
if is_windows() {
162162
if is_msvc() { vec![] } else { vec!["-lstdc++"] }
163163
} else {
164-
match uname() {
165-
n if n.contains("Darwin") => vec!["-lc++"],
164+
match &uname()[..] {
165+
"Darwin" => vec!["-lc++"],
166+
"FreeBSD" | "SunOS" | "OpenBSD" => vec![],
166167
_ => vec!["-lstdc++"],
167168
}
168169
}

0 commit comments

Comments
 (0)