Skip to content

Commit 8192eb1

Browse files
committed
SPRNGCORE-6: Fix deprecated code and ambiguous issues.
Address newly deprecated code issues. Address ambiguous `any()` issue that now appears and breaks tests. The `@MockBean` is no longer available and we must instead use `@MockitoBean`. see: spring-projects/spring-framework#29917 (comment) see: spring-projects/spring-framework#33925 see: https://docs.spring.io/spring-framework/reference/testing/annotations/integration-spring/annotation-mockitobean.html
1 parent 7f46733 commit 8192eb1

File tree

5 files changed

+11
-10
lines changed

5 files changed

+11
-10
lines changed

Diff for: domain/src/test/java/org/folio/spring/domain/controller/JsonSchemasControllerTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@
5353
import org.springframework.beans.factory.annotation.Autowired;
5454
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
5555
import org.springframework.boot.test.context.SpringBootTest;
56-
import org.springframework.boot.test.mock.mockito.MockBean;
5756
import org.springframework.http.HttpHeaders;
5857
import org.springframework.http.MediaType;
58+
import org.springframework.test.context.bean.override.mockito.MockitoBean;
5959
import org.springframework.test.web.servlet.MockMvc;
6060
import org.springframework.test.web.servlet.MvcResult;
6161
import org.springframework.test.web.servlet.request.MockHttpServletRequestBuilder;
@@ -71,7 +71,7 @@ class JsonSchemasControllerTest {
7171
@Autowired
7272
private MockMvc mvc;
7373

74-
@MockBean
74+
@MockitoBean
7575
private JsonSchemasService jsonSchemasService;
7676

7777
@ParameterizedTest

Diff for: domain/src/test/java/org/folio/spring/domain/controller/RamlsControllerTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,9 @@
5353
import org.springframework.beans.factory.annotation.Autowired;
5454
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
5555
import org.springframework.boot.test.context.SpringBootTest;
56-
import org.springframework.boot.test.mock.mockito.MockBean;
5756
import org.springframework.http.HttpHeaders;
5857
import org.springframework.http.MediaType;
58+
import org.springframework.test.context.bean.override.mockito.MockitoBean;
5959
import org.springframework.test.web.servlet.MockMvc;
6060
import org.springframework.test.web.servlet.MvcResult;
6161
import org.springframework.test.web.servlet.request.MockHttpServletRequestBuilder;
@@ -71,7 +71,7 @@ class RamlsControllerTest {
7171
@Autowired
7272
private MockMvc mvc;
7373

74-
@MockBean
74+
@MockitoBean
7575
private RamlsService ramlsService;
7676

7777
@ParameterizedTest

Diff for: domain/src/test/java/org/folio/spring/domain/generator/FolioUUIDGeneratorTest.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import static org.mockito.Mockito.lenient;
99
import static org.mockito.Mockito.when;
1010

11+
import org.hibernate.engine.spi.SharedSessionContractImplementor;
1112
import org.hibernate.id.enhanced.AccessCallback;
1213
import org.hibernate.id.enhanced.DatabaseStructure;
1314
import org.hibernate.id.enhanced.Optimizer;
@@ -51,7 +52,7 @@ void beforeEach() {
5152

5253
@Test
5354
void generateWorksTest() {
54-
when(persister.getIdentifier(any(), any())).thenReturn(UUID);
55+
when(persister.getIdentifier(any(), any(SharedSessionContractImplementor.class))).thenReturn(UUID);
5556

5657
Object result = folioUUIDGenerator.generate(session, folioUUIDGenerator);
5758

@@ -60,7 +61,7 @@ void generateWorksTest() {
6061

6162
@Test
6263
void generateWorksWithNullIdentifierTest() {
63-
when(persister.getIdentifier(any(), any())).thenReturn(null);
64+
when(persister.getIdentifier(any(), any(SharedSessionContractImplementor.class))).thenReturn(null);
6465
when(databaseStructure.buildCallback(any())).thenReturn(accessCallback);
6566
when(optimizer.generate(any())).thenReturn(JSON_OBJECT);
6667

Diff for: tenant/src/test/java/org/folio/spring/tenant/controller/TenantControllerTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@
4242
import org.springframework.beans.factory.annotation.Autowired;
4343
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
4444
import org.springframework.boot.test.context.SpringBootTest;
45-
import org.springframework.boot.test.mock.mockito.MockBean;
4645
import org.springframework.http.HttpHeaders;
4746
import org.springframework.http.MediaType;
47+
import org.springframework.test.context.bean.override.mockito.MockitoBean;
4848
import org.springframework.test.web.servlet.MockMvc;
4949
import org.springframework.test.web.servlet.MvcResult;
5050
import org.springframework.test.web.servlet.request.MockHttpServletRequestBuilder;
@@ -60,7 +60,7 @@ class TenantControllerTest {
6060
@Autowired
6161
private MockMvc mvc;
6262

63-
@MockBean
63+
@MockitoBean
6464
private HibernateSchemaService hibernateSchemaService;
6565

6666
@ParameterizedTest

Diff for: web/src/main/java/org/folio/spring/web/service/HttpService.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ public void setup() {
4444
messageConverters.add(new ObjectPlainTextConverter(StandardCharsets.UTF_8));
4545

4646
this.restTemplate = restTemplateBuilder
47-
.setConnectTimeout(Duration.ofSeconds(connectionTimeout))
48-
.setReadTimeout(Duration.ofSeconds(readTimeout))
47+
.connectTimeout(Duration.ofSeconds(connectionTimeout))
48+
.readTimeout(Duration.ofSeconds(readTimeout))
4949
.additionalMessageConverters(messageConverters)
5050
.build();
5151
}

0 commit comments

Comments
 (0)