fix(install): dont try re-installing failed missing plugins during startup. Fixes #303

Author: folke

lua/lazy/core/loader.lua

@@ -33,7 +33,12 @@ function M.setup()
   -- install missing plugins
   if Config.options.install.missing then
     Util.track("install")
+    local count = 0
     while M.install_missing() do
+      count = count + 1
+      if count > 5 then
+        break
+      end
     end
     Util.track()
   end
@@ -51,7 +56,7 @@ end
 -- multiple rounds can happen when importing a spec from a missing plugin
 function M.install_missing()
   for _, plugin in pairs(Config.plugins) do
-    if not plugin._.installed then
+    if not (plugin._.installed or Plugin.has_errors(plugin)) then
       for _, colorscheme in ipairs(Config.options.install.colorscheme) do
         if pcall(vim.cmd.colorscheme, colorscheme) then
           break
@@ -64,8 +69,6 @@ function M.install_missing()
           Cache.indexed[p.dir] = nil
         end
       end
-      -- clear plugins. no need to merge in this stage
-      Config.plugins = {}
       -- reload plugins
       Plugin.load()
       return true

lua/lazy/core/plugin.lua

@@ -326,4 +326,14 @@ function M.find(path)
   end
 end
 
+---@param plugin LazyPlugin
+function M.has_errors(plugin)
+  for _, task in ipairs(plugin._.tasks or {}) do
+    if task.error then
+      return true
+    end
+  end
+  return false
+end
+
 return M

lua/lazy/manage/checker.lua

@@ -1,6 +1,7 @@
 local Config = require("lazy.core.config")
 local Manage = require("lazy.manage")
 local Util = require("lazy.util")
+local Plugin = require("lazy.core.plugin")
 local Git = require("lazy.manage.git")
 
 local M = {}
@@ -31,13 +32,24 @@ function M.fast_check(opts)
 end
 
 function M.check()
-  Manage.check({
-    show = false,
-    concurrency = Config.options.checker.concurrency,
-  }):wait(function()
-    M.report()
+  local errors = false
+  for _, plugin in pairs(Config.plugins) do
+    if Plugin.has_errors(plugin) then
+      errors = true
+      break
+    end
+  end
+  if errors then
     vim.defer_fn(M.check, Config.options.checker.frequency * 1000)
-  end)
+  else
+    Manage.check({
+      show = false,
+      concurrency = Config.options.checker.concurrency,
+    }):wait(function()
+      M.report()
+      vim.defer_fn(M.check, Config.options.checker.frequency * 1000)
+    end)
+  end
 end
 
 ---@param notify? boolean