bug: the latest commit keys first trigger not work

[huwqchn]

Did you check docs and existing issues?

• I have read all the lazy.nvim docs
• I have searched the existing issues of lazy.nvim
• I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)

0.8.2

Operating system/version

arch 6.1.9

Describe the bug

Steps To Reproduce

1. update lazy
2. add config

return {
  {
    "numToStr/Comment.nvim",
    keys = {
      { "gc", mode = { "n", "v", "x" } },
      { "gb", mode = { "n", "v", "x" } },
      {
        "<leader>/",
        function()
          require("Comment.api").toggle.linewise.current()
        end,
        mode = "n",
        desc = "Comment",
      },
      {
        "<leader>/",
        "<Plug>(comment_toggle_linewise_visual)",
        mode = "v",
        desc = "Comment toggle linewise (visual)",
      },
    },
    config = function()
      local pre_hook
      local ts_comment = require("ts_context_commentstring.integrations.comment_nvim")
      pre_hook = ts_comment.create_pre_hook()

      require("Comment").setup({
        ---Add a space b/w comment and the line
        ---@type boolean
        padding = true,

        ---Whether cursor should stay at the
        ---same position. Only works in NORMAL
        ---mode mappings
        sticky = true,

        ---Lines to be ignored while comment/uncomment.
        ---Could be a regex string or a function that returns a regex string.
        ---Example: Use '^$' to ignore empty lines
        ---@type string|function
        ignore = "^$",

        ---Whether to create basic (operator-pending) and extra mappings for NORMAL/VISUAL mode
        ---@type table
        mappings = {
          ---operator-pending mapping
          ---Includes `gcc`, `gcb`, `gc[count]{motion}` and `gb[count]{motion}`
          basic = true,
          ---Extra mapping
          ---Includes `gco`, `gcO`, `gcA`
          extra = true,
        },

        ---LHS of line and block comment toggle mapping in NORMAL/VISUAL mode
        ---@type table
        toggler = {
          ---line-comment toggle
          line = "gcc",
          ---block-comment toggle
          block = "gbc",
        },

        ---LHS of line and block comment operator-mode mapping in NORMAL/VISUAL mode
        ---@type table
        opleader = {
          ---line-comment opfunc mapping
          line = "gc",
          ---block-comment opfunc mapping
          block = "gb",
        },

        ---LHS of extra mappings
        ---@type table
        extra = {
          ---Add comment on the line above
          above = "gcO",
          ---Add comment on the line below
          below = "gco",
          ---Add comment at the end of line
          eol = "gcA",
        },

        ---Pre-hook, called before commenting the line
        ---@type function|nil
        pre_hook = pre_hook,

        ---Post-hook, called after commenting is done
        ---@type function|nil
        post_hook = nil,
      })
    end,
  },
}
3. type <space>/

Expected Behavior

expect first trigger key work

Repro

[folke]

For what key? Can you please add the steps/keys to type that don't seem to work for you?

[folke]

Also, please provide a minimal repro as instructed in the issue template

[folke]

repro:

Do gcc

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  {
    "numToStr/Comment.nvim",
    keys = {
      { "gc", mode = { "n", "v", "x" } },
      { "gb", mode = { "n", "v", "x" } },
      {
        "<leader>/",
        function()
          require("Comment.api").toggle.linewise.current()
        end,
        mode = "n",
        desc = "Comment",
      },
      {
        "<leader>/",
        "<Plug>(comment_toggle_linewise_visual)",
        mode = "v",
        desc = "Comment toggle linewise (visual)",
      },
    },
    config = function()
      require("Comment").setup()
    end,
  },
}

require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")

[folke]

Works on nightly, but not on stable. Will look into it

[huwqchn]

Sorry for that.
All keymaps added in keys will not take effect on the first press.

[folke]

You need to add gcc separately since that keymap is a normal keymap created by comment.nvim

[huwqchn]

Thanks, works now

[nxmxsxs]

@folke
I'm still facing weird behaviours on neovim 0.8.3 after ddaffa0:
I'm posting here because they're kinda related but I can open a new issue if necessary.

repro.lua

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify('./.repro', ':p')

-- set stdpaths to use .repro
for _, name in ipairs { 'config', 'data', 'state', 'cache' } do
vim.env[('XDG_%s_HOME'):format(name:upper())] = root .. '/' .. name
end

-- bootstrap lazy
local lazypath = root .. '/plugins/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
vim.fn.system {
  'git',
  'clone',
  '--filter=blob:none',
  '--single-branch',
  'https://github.com/folke/lazy.nvim.git',
  lazypath,
}
end
vim.opt.runtimepath:prepend(lazypath)

vim.opt.number = true
vim.opt.relativenumber = true
vim.opt.scrolloff = 16

local plugins = {
{
  'folke/tokyonight.nvim',
  lazy = false,
  config = function()
    vim.cmd.colorscheme 'tokyonight'
  end,
},
{
  'nvim-neo-tree/neo-tree.nvim',
  dependencies = {
    { 'MunifTanjim/nui.nvim' },
    { 'nvim-lua/plenary.nvim' },
  },
  cmd = { 'Neotree' },
  keys = {
    {
  '<C-p>',
  '<cmd>Neotree toggle<cr>',
  mode = { 'n' },
    },
  },
  config = function()
    require('neo-tree').setup {}
  end,
},
{
  'akinsho/toggleterm.nvim',
  keys = {
    {
  [[<C-\>]],
  function()
    require('toggleterm').toggle(vim.v.count)
  end,
  mode = { 'n' },
    },

    {
  '<leader>tt',
  function()
    require('toggleterm').toggle_all(true)
  end,
  mode = { 'n' },
    },
  },
  config = function()
    local size = {
  horizontal = 15,
  vertical = vim.o.columns * 0.4,
    }

    require('toggleterm').setup {
  size = function(term)
    return size[term.direction]
  end,
  shade_terminals = false,
    }
  end,
},
{
  'mg979/vim-visual-multi',
  keys = {
    { '<C-n>', mode = { 'n' } },
  },
}
}

require('lazy').setup(plugins, {
root = root .. '/plugins',
defaults = {
  lazy = true,
}
})

toggleterm and neo-tree needs to be pressed twice in order to trigger but vim-visual-multi works regardless.
Also if I change mode (for example) before triggering then it works as expected 😕

vice-versa on 4272d21

2023-02-08.14-18-40.mov

[folke]

Hopefully I fixed it for good now. I re-tested all closed issues related to the keys handler on Neovim stable. All those cases at least seem to work fine again. (including yours)

[nxmxsxs]

Awesome! That seems to have fixed it. Do you know what cause the change between master and stable?

[folke]

Couldn't find the exact cause, but it has something to do with keymaps returning an expression for another keymap that has been created while evaluating the keymap :)

It seems as if on stable, that new keymap is not known.

But I found another way to work around this and make it work.

The new approach (as the one that broke) is much simpler than before, but it's always tricky to make changes to the keys handler due to all the quirks related to Neovim keymaps.